Skip to content

Vouch request: mahenoorsalat — fix for #4984 (object-store 404 with empty reason phrase) #4989

Description

@mahenoorsalat

Why do you want to contribute?

I would like to fix a bug I found in the webapp transcript download path: a missing transcript returns 502 instead of 404 when the object store's 404 response has an empty reason phrase (issue #4984). I already implemented the fix (thrown download errors carry the HTTP status; isTranscriptNotFound checks status first, plus a regression test and .server-changes note) as PR #4987, which was auto-closed because I am not vouched yet. I would like to be vouched so the fix can be reviewed and reopened.

Prior contributions or relevant experience

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions