Repository navigation
Fix the CRAN pretest findings and bump to 1.3.6-0.6.2 - #19
Merged
Merged
Conversation
- bump to 1.3.6-0.6.2 and advance the engine pin to the Rtools45 toolchain fix and the CRPFreeFileNames prototype fix - README: use the sdcweb.org URL without the 301 redirect and link the compatibility guide by its repository URL (docs/ is not part of the package) - vignettes: point the issue report link at the repository issue tracker; the INSEE gitlab host is not resolvable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the CRAN resubmission of rtauargus.native (1.3.6-0.6.2) after the 1.3.6-0.6.1 pretest rejection.
Fixes the three findings:
configure.Rfix that resolves the Rtools45 toolchain (compiler, C++ compiler, make) and passes it to CMake explicitly; this build's Windows job (R 4.5.3, Rtools45) exercises it.WrapCRP.cstrict-prototype) - the engine pin advances to the crpCRPFreeFileNames(void)fix.sdcweb.org/tau-argus/(no 301) and the compatibility guide by its repository URL instead of the in-repodocs/path that is not shipped in the package; the vignette issue-report link points at the repository issue tracker becausegitlab.insee.fris not resolvable.Version: 1.3.6-0.6.1 to 1.3.6-0.6.2 (required for a CRAN resubmission),
Config/tauargus/native-versionto 0.6.2, engine pin tof3a6b2d(engine master, PR InseeFrLab#38).