Conversation
| }, nil | ||
| ``` | ||
|
|
||
| ### 2. SHA resolution in `ensureObject` |
There was a problem hiding this comment.
SHA resolution in ensureObject
not sure if understand this part? is this suggesting to fetch from the underlying staging git repo?
There was a problem hiding this comment.
Yes - basically convert the underlying staging ref to a sha.
| // tryApply uses the resolved steps | ||
| ``` | ||
|
|
||
| ### 4. Configurable staging ref format |
There was a problem hiding this comment.
- Configurable staging ref format
do we need anything in OSS for this? i would assume we can add this internally and not add anything to OSS... leverage GitFarm for git ops
There was a problem hiding this comment.
Updated the PR per discussion offline.
|
|
||
| Object resolution (fetching commits, resolving refs to SHAs, checking staleness) is currently embedded in the git merger. This RFC extracts it into a pluggable interface so the same orchestration logic works with any VCS backend — the OSS git implementation, or an alternative implementation that a deployment substitutes. | ||
|
|
||
| ``` |
There was a problem hiding this comment.
│ └── resolver.go — ObjectResolver interface + shared orchestration
can this resolve be internal to git? i am thinking we just need to get the git commit? can it be just get commit for Phab, get commit for PR and so on. Interface also looks very gitty so make sense to keep that sub-extension under git? Thoughts.
then you end up different objectResolve or changeresolver for github, phab, git, gitlab etc?
This branch has not been deployed
2 participants
Why?
This change helps onboard Phabricator repos to SubmitQueue.
What?
This PR proposes adding
phab://change URI support to Runway's git merger so Phabricator-based repositories can use SubmitQueue end-to-end.Test Plan
RFC only; code changes to follow.
Issue