Repository navigation
chore(fixtures): sync drifted scaffold snapshots - #453
Conversation
Regenerated via `bun run fixtures:sync`. All 8 templates drifted, not just expo. Upstream changes absorbed: - expo ~55.0.30 -> ~55.0.31 (expo, expo-auth) - @base-ui/react ^1.7.0 -> ^1.8.0, lucide-react ^1.34.0 -> ^1.41.0 (6 shadcn) - shadcn cn migration: clsx + tailwind-merge -> cn@^0.2.5; lib/utils.ts now re-exports, button.tsx imports from cn (6 shadcn) - new .npmrc with legacy-peer-deps=true (start, start-auth) No packages/ change, so no changeset.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8219887abd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@zbeyens suggest merging this one first.
Once this merges, re-run CI on those PRs and the fixtures failure should clear without any change on their side. One thing worth a look before merging, since it's more than a version bump: shadcn replaced |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 419d5411d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Exact head: Ready for authorized merge; this receipt does not claim the merge has happened.
#453 is the first PR selected from the new batch. Its accepted fixture refresh includes cn ^0.2.6 in all six shadcn manifests. Proof and gates:
Complete feedback disposition:
This external receipt supplies final post-push review/proof/read-back evidence for the closeout checkpoint; no receipt-only branch commit is created. Floating upstream snapshots and the approved Start peer-dependency setting remain the stated scope risks. |
🐛 Fixes ➖ N/A
🧭 Task plan: docs/plans/2026-09-06-sync-drifted-scaffold-fixtures.md
🟢 95-100% confidence
fixtures:check→FixtureDriftErroronexpo(-"expo": "~55.0.30"/+"expo": "~55.0.31")fixtures:checkexit 0, 8/8 match ·bun checkexit 0✅ Outcome
Regenerated
fixtures/**withbun run fixtures:sync. All 8 templates had drifted, not just the 2 expo ones. Four distinct upstream changes absorbed:expo ~55.0.30 → ~55.0.31@base-ui/react ^1.7.0 → ^1.8.0,lucide-react ^1.34.0 → ^1.41.0clsx+tailwind-mergeremoved →cn@^0.2.6;lib/utils.tsrewritten toexport { cn } from "cn";button.tsximports fromcn.npmrcwithlegacy-peer-deps=truecnis first-party to shadcn (shadcn-ui/cn, MIT, maintainershadcn <[email protected]>) — a compiled drop-in forclsx+tailwind-merge.Two items are not routine version bumps and were confirmed with the repo owner before commit.
cnbecomes a runtime dependency of every app kitcn scaffolds, andlegacy-peer-deps=truesuppresses peer-conflict errors in generated start apps, which can mask real incompatibilities.shadcnis pinned to the literallatest, so registry content churn — not just semver — will keep arriving through this lane, andfixtures:checkcannot distinguish the two.🏗️ Design
fixtures/**is generated output, so the only correct response to upstream movement is regeneration via the owning tool — hand-editing would desync the snapshot from real scaffolder output. No pinning or template change was made: nothing in this repo is wrong, so that would be scope creep and a separate decision.No changeset: the diff touches zero files under
packages/. Verified rather than assumed —fixtures:syncalso runsdependency-pins.ts sync, which can write topackages/kitcn/package.jsonand a skills doc, so that step was run in isolation first and produced no diff (it derives fromsupported-dependencies.tsconstants, not npm).🧪 Verified
bun check→ exit 0: 1400 Bun tests, 981 Vitest tests (14 skipped), 124 CLI tests, Concave smoke, fixtures:check 8/8, test:verify and test:runtime.fixtures:check→ exit 0, all 8 "matches fresh … output"grep -rln "legacy-peer-deps" packages/kitcn/andgit ls-files | grep npmrc→ no matches, confirming.npmrcis upstream, not repo-ownedNote for local runs: this lane needs
bun build:pkg(kitcn and resend), not just the kitcn build — it otherwise dies onENOENT .../packages/resend/distbefore comparing anything. CI already does this.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.