Skip to content

chore(fixtures): sync drifted scaffold snapshots - #453

Merged
zbeyens merged 5 commits into
mainfrom
chore/sync-drifted-scaffold-fixtures
Sep 7, 2026
Merged

zbeyens merged 5 commits into
mainfrom
chore/sync-drifted-scaffold-fixtures

Conversation

@MikeyZhang75

@MikeyZhang75 MikeyZhang75 commented Sep 6, 2026 •

Copy link
Copy Markdown
Collaborator

🐛 Fixes ➖ N/A

🧭 Task plan: docs/plans/2026-09-06-sync-drifted-scaffold-fixtures.md

🟢 95-100% confidence

Phase 🧪 Tests 🌐 Browser
Reproduced 🔴 fixtures:check → FixtureDriftError on expo (-"expo": "~55.0.30" / +"expo": "~55.0.31") ➖ N/A
Verified 🟢 fixtures:check exit 0, 8/8 match · bun check exit 0 ➖ N/A

✅ Outcome

Regenerated fixtures/** with bun run fixtures:sync. All 8 templates had drifted, not just the 2 expo ones. Four distinct upstream changes absorbed:

# Change Fixtures Kind
1 expo ~55.0.30 → ~55.0.31 expo, expo-auth dependency bump
2 @base-ui/react ^1.7.0 → ^1.8.0, lucide-react ^1.34.0 → ^1.41.0 6 shadcn dependency bump
3 clsx + tailwind-merge removed → cn@^0.2.6; lib/utils.ts rewritten to export { cn } from "cn"; button.tsx imports from cn 6 shadcn source migration
4 new .npmrc with legacy-peer-deps=true start, start-auth new generated file

cn is first-party to shadcn (shadcn-ui/cn, MIT, maintainer shadcn <[email protected]>) — a compiled drop-in for clsx + tailwind-merge.

⚠️ Caveat

Two items are not routine version bumps and were confirmed with the repo owner before commit. cn becomes a runtime dependency of every app kitcn scaffolds, and legacy-peer-deps=true suppresses peer-conflict errors in generated start apps, which can mask real incompatibilities. shadcn is pinned to the literal latest, so registry content churn — not just semver — will keep arriving through this lane, and fixtures:check cannot distinguish the two.

🏗️ Design

fixtures/** is generated output, so the only correct response to upstream movement is regeneration via the owning tool — hand-editing would desync the snapshot from real scaffolder output. No pinning or template change was made: nothing in this repo is wrong, so that would be scope creep and a separate decision.

No changeset: the diff touches zero files under packages/. Verified rather than assumed — fixtures:sync also runs dependency-pins.ts sync, which can write to packages/kitcn/package.json and a skills doc, so that step was run in isolation first and produced no diff (it derives from supported-dependencies.ts constants, not npm).

🧪 Verified

  • bun check → exit 0: 1400 Bun tests, 981 Vitest tests (14 skipped), 124 CLI tests, Concave smoke, fixtures:check 8/8, test:verify and test:runtime.
  • P1 autoreview against the committed branch: clean; task-state regression assertions and plan checker passed after push.
  • fixtures:check → exit 0, all 8 "matches fresh … output"
  • Every diff hunk classified: the 22-file fixture diff collapses to exactly 5 manifest lines and 2 source transformations
  • grep -rln "legacy-peer-deps" packages/kitcn/ and git ls-files | grep npmrc → no matches, confirming .npmrc is upstream, not repo-owned

Note for local runs: this lane needs bun build:pkg (kitcn and resend), not just the kitcn build — it otherwise dies on ENOENT .../packages/resend/dist before comparing anything. CI already does this.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Regenerated via `bun run fixtures:sync`. All 8 templates drifted, not just expo.

Upstream changes absorbed:
- expo ~55.0.30 -> ~55.0.31 (expo, expo-auth)
- @base-ui/react ^1.7.0 -> ^1.8.0, lucide-react ^1.34.0 -> ^1.41.0 (6 shadcn)
- shadcn cn migration: clsx + tailwind-merge -> cn@^0.2.5; lib/utils.ts now
  re-exports, button.tsx imports from cn (6 shadcn)
- new .npmrc with legacy-peer-deps=true (start, start-auth)

No packages/ change, so no changeset.
@changeset-bot

changeset-bot Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 98a7434

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
better-convex Ready Ready Preview Sep 6, 2026 7:21pm UTC

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8219887abd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MikeyZhang75

MikeyZhang75 commented Sep 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

@zbeyens suggest merging this one first.

fixtures:check is currently red on main itself — upstream published [email protected] plus a shadcn registry migration after the last fixture sync, and the lane regenerates against live npm. So every open PR (#448–#452) inherits the same red fixtures lane even though none of them touch fixtures/**.

Once this merges, re-run CI on those PRs and the fixtures failure should clear without any change on their side.

One thing worth a look before merging, since it's more than a version bump: shadcn replaced clsx + tailwind-merge with their new first-party cn package, so lib/utils.ts and button.tsx are rewritten in all 6 shadcn fixtures, and start/start-auth now get an .npmrc with legacy-peer-deps=true. Details in the description.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-06T19:23:45.534406Z 98a7434 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 419d5411d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zbeyens

zbeyens commented Sep 6, 2026

Copy link
Copy Markdown
Member

Exact head: 98a7434c81a7c93b6abded9f4df3b836de5068c1.

Ready for authorized merge; this receipt does not claim the merge has happened.

suggest merging this one first

#453 is the first PR selected from the new batch. Its accepted fixture refresh includes cn ^0.2.6 in all six shadcn manifests.

Proof and gates:

  • Dedicated task plan verified in the body and at the fetched head; it owns exactly chore(fixtures): sync drifted scaffold snapshots #453.
  • Local committed HEAD = fetched refs/pr/453 = live GitHub head.
  • NO_PROXY=localhost,127.0.0.1 bun check passed at this commit: 1400 Bun tests, 981 Vitest tests (14 skipped), 124 CLI tests, Concave smoke, all 8 fixture comparisons, CLI verification and prepared-runtime checks.
  • fixtures:sync passed for all 8 templates; no hand-edited generated output.
  • Stable committed-branch autoreview --mode branch --base origin/main --max-priority P1 passed with no accepted/actionable findings.
  • After the final push, both P1 proof sets passed: task-state/PR-ownership assertions, six-manifest/current-plan version assertions, and the dedicated task-plan checker.
  • Hosted CI passed; Vercel passed; hosted Codex review completed at this head.
  • Full helper inventory: 0 unresolved threads, 2 top-level comments, 2 review bodies.
  • Unfiltered inventory: 4 top-level comments, 5 review bodies, 2 resolved / 0 unresolved threads containing 5 comments. All pages fetched; helper exclusions are 2 top-level comments and 3 review bodies.
  • Two P1 findings fixed and resolved; zero unresolved actionable P0/P1 findings. No deferred defect. The merge-order request is addressed, not silently deferred.

Complete feedback disposition:

This external receipt supplies final post-push review/proof/read-back evidence for the closeout checkpoint; no receipt-only branch commit is created. Floating upstream snapshots and the approved Start peer-dependency setting remain the stated scope risks.

@zbeyens
zbeyens merged commit 8e205dc into main Sep 7, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 98a7434c Deployed Sep 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants