Repository navigation
Fall back to 1mm outboard SOL power decay in plotting - #4621
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4621 +/- ##
==========================================
- Coverage 50.26% 50.26% -0.01%
==========================================
Files 181 181
Lines 30627 30629 +2
==========================================
Hits 15395 15395
- Misses 15232 15234 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
approved these changes
Oct 9, 2026
timothy-nunn
force-pushed
the
4620-bug---full-output-errors-and-damaged-pdf
branch
from
October 20, 2026 10:18
21483cb to
00f3265
Compare
clmould
approved these changes
Oct 20, 2026
clmould
enabled auto-merge (squash)
October 20, 2026 10:25
clmould
disabled auto-merge
October 20, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks for invalid values of
len_sol_outboard_power_decaywhen plotting to avoid 0/non-finite plot axis lengths. There was a pre-existing comment to suggest this should have been happening but had been removed.Looking at the code which produces this variable, non-finite outputs can occur if the power or magnetic field is negative.
PROCESS/process/models/physics/scrape_off_layer.py
Lines 275 to 281 in 2ae0ef2