Skip to content

Fall back to 1mm outboard SOL power decay in plotting - #4621

Merged
clmould merged 1 commit into
mainfrom
4620-bug---full-output-errors-and-damaged-pdf
Oct 20, 2026
Merged

clmould merged 1 commit into
mainfrom
4620-bug---full-output-errors-and-damaged-pdf

Conversation

@timothy-nunn

Copy link
Copy Markdown
Collaborator

Checks for invalid values of len_sol_outboard_power_decay when plotting to avoid 0/non-finite plot axis lengths. There was a pre-existing comment to suggest this should have been happening but had been removed.

Looking at the code which produces this variable, non-finite outputs can occur if the power or magnetic field is negative.

return (
1.35e-3
* p_plasma_separatrix_mw**-0.02
* rmajor**0.04
* b_plasma_surface_poloidal_average**-0.92
* aspect**-0.42
)

@timothy-nunn timothy-nunn linked an issue Sep 29, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.26%. Comparing base (830360e) to head (00f3265).

Files with missing lines Patch % Lines
process/core/io/plot/summary/plasma/sol.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4621      +/-   ##
==========================================
- Coverage   50.26%   50.26%   -0.01%     
==========================================
  Files         181      181              
  Lines       30627    30629       +2     
==========================================
  Hits        15395    15395              
- Misses      15232    15234       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn
timothy-nunn marked this pull request as ready for review September 29, 2026 09:12
@timothy-nunn
timothy-nunn requested a review from a team as a code owner September 29, 2026 09:12
@timothy-nunn
timothy-nunn requested a review from a team October 9, 2026 08:01
@timothy-nunn
timothy-nunn removed the request for review from CoronelBuendia October 9, 2026 08:37
@timothy-nunn
timothy-nunn force-pushed the 4620-bug---full-output-errors-and-damaged-pdf branch from 21483cb to 00f3265 Compare October 20, 2026 10:18
@clmould
clmould enabled auto-merge (squash) October 20, 2026 10:25
@clmould
clmould disabled auto-merge October 20, 2026 10:29
@clmould
clmould merged commit 9d98330 into main Oct 20, 2026
20 of 22 checks passed
@clmould
clmould deleted the 4620-bug---full-output-errors-and-damaged-pdf branch October 20, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 --full-output errors and damaged PDF

4 participants