Skip to content

4582 possible duplicate variable - #4708

Open
grmtrkngtn wants to merge 13 commits into
mainfrom
4582-possible-duplicate-variable
Open

grmtrkngtn wants to merge 13 commits into
mainfrom
4582-possible-duplicate-variable

Conversation

@grmtrkngtn

Copy link
Copy Markdown
Collaborator

Description

This PR removes two duplicated impurity-radiation data structures:

f_nd_impurity_electron_array is removed in favour of the existing canonical f_nd_impurity_electrons array.

impurity_arr_label is removed in favour of the existing imp_label array.

All impurity iteration variables, radiation calculations, lookups and output now use the canonical arrays directly.

The active impurity species continue to be determined from the non-zero values in f_nd_impurity_electrons, so no separate active-impurity label state is required.

closes #4636

@grmtrkngtn grmtrkngtn self-assigned this Oct 23, 2026
@grmtrkngtn
grmtrkngtn requested a review from a team as a code owner October 23, 2026 15:01
@grmtrkngtn grmtrkngtn added Impurities Plasma impurities Bug Something isnt working labels Oct 23, 2026
@grmtrkngtn grmtrkngtn linked an issue Oct 23, 2026 that may be closed by this pull request
@codecov-commenter

codecov-commenter commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.24%. Comparing base (0b69cfc) to head (f443f8c).

Files with missing lines Patch % Lines
process/models/physics/impurity_radiation.py 50.00% 2 Missing ⚠️
process/models/physics/physics.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4708      +/-   ##
==========================================
- Coverage   50.26%   50.24%   -0.02%     
==========================================
  Files         181      181              
  Lines       30629    30615      -14     
==========================================
- Hits        15395    15384      -11     
+ Misses      15234    15231       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working Impurities Plasma impurities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up use of impurity_arr_label Possible duplicate variable

2 participants