Repository navigation
4582 possible duplicate variable - #4708
Open
grmtrkngtn wants to merge 13 commits into
Open
grmtrkngtn wants to merge 13 commits into
grmtrkngtn wants to merge 13 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4708 +/- ##
==========================================
- Coverage 50.26% 50.24% -0.02%
==========================================
Files 181 181
Lines 30629 30615 -14
==========================================
- Hits 15395 15384 -11
+ Misses 15234 15231 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…on, remove defunct variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes two duplicated impurity-radiation data structures:
All impurity iteration variables, radiation calculations, lookups and output now use the canonical arrays directly.
The active impurity species continue to be determined from the non-zero values in f_nd_impurity_electrons, so no separate active-impurity label state is required.
closes #4636