Skip to content

Fix bibliography anchors and populate the empty asciiunits bibliography - #24

Merged
ronaldtse merged 1 commit into
mainfrom
fix/bibliography-rendering
Nov 3, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
fix/bibliography-rendering

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

Summary

Validating the rendered documents against the truncation report found, in this register:

  1. Malformed CalConnect anchors in six parts' normative references ([[[unitsml-3682,nofetch(CalConnect 36813]]] — wrong id, missing closing paren): they rendered as broken text with [NO INFORMATION AVAILABLE] chips. All are well-formed [[[unitsml-3681x,nofetch(CalConnect 3681x)]]] anchors now (36814, 36815, 36816, 36817, 36818, 36819).
  2. unitsdb normative reference used a double-bracket anchor ([[SI_Brochure,...]]) — now a proper citation anchor.
  3. 36819 testsuite entry contained a raw # that produced an empty citation chip — reworded.
  4. asciiunits document ended at a bare "Bibliography" heading with zero entries (the truncation the report described); it now cites the unitsml-ruby parser the grammar was extracted from and the asciiunits artifact repository — factual references drawn from the document's own provenance statements.
  5. Validator pass (scripts/validate-register.rb): new bibliography checks — missing [bibliography] markers, unanchored entries, multi-anchor entries, unbalanced nofetch( — negative-tested; the 36812–36819 register validates clean.

Note: unitsml-guide, unitsml-incorporation, unitsml-ubl-ndr-subset are commented out of metanorma.yml — their 404s on the site are the intended build list, not truncation.

Test plan

  • ruby scripts/validate-register.rb — VALIDATION OK (13 documents)
  • Negative test of the new validator pass — all defect classes reported
  • Local metanorma compile spot-checks of fixed sections (full register compile happens in CI)
  • Reviewer: spot-check rendered 36816 (CalConnect anchors) and asciiunits (populated Bibliography) after Pages rebuild

Several bibliography entries rendered as broken citation chips or empty
"[NO INFORMATION AVAILABLE]" placeholders: the CalConnect anchors in six
parts carried malformed ids and unbalanced nofetch( parentheses
(unitsml-3682/nofetch(CalConnect 36813]]] and friends), the unitsdb
normative reference used a double-bracket anchor, and the 36819
testsuite entry contained a raw # that produced an empty citation. All
are well-formed [[[id,nofetch(text)]]] anchors now.

The asciiunits document ended at a bare "Bibliography" heading with no
entries; it now cites the unitsml-ruby parser the grammar was extracted
from and the asciiunits artifact repository.

The register validator gains a bibliography pass so this defect class
fails CI instead of rendering: missing [bibliography] markers,
unanchored entries, multi-anchor entries, and unbalanced nofetch(
parentheses.
@ronaldtse
ronaldtse merged commit 1c70489 into main Nov 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant