Repository navigation
Fix bibliography anchors and populate the empty asciiunits bibliography - #24
Merged
Merged
Conversation
Several bibliography entries rendered as broken citation chips or empty "[NO INFORMATION AVAILABLE]" placeholders: the CalConnect anchors in six parts carried malformed ids and unbalanced nofetch( parentheses (unitsml-3682/nofetch(CalConnect 36813]]] and friends), the unitsdb normative reference used a double-bracket anchor, and the 36819 testsuite entry contained a raw # that produced an empty citation. All are well-formed [[[id,nofetch(text)]]] anchors now. The asciiunits document ended at a bare "Bibliography" heading with no entries; it now cites the unitsml-ruby parser the grammar was extracted from and the asciiunits artifact repository. The register validator gains a bibliography pass so this defect class fails CI instead of rendering: missing [bibliography] markers, unanchored entries, multi-anchor entries, and unbalanced nofetch( parentheses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validating the rendered documents against the truncation report found, in this register:
[[[unitsml-3682,nofetch(CalConnect 36813]]]— wrong id, missing closing paren): they rendered as broken text with[NO INFORMATION AVAILABLE]chips. All are well-formed[[[unitsml-3681x,nofetch(CalConnect 3681x)]]]anchors now (36814, 36815, 36816, 36817, 36818, 36819).[[SI_Brochure,...]]) — now a proper citation anchor.#that produced an empty citation chip — reworded.scripts/validate-register.rb): new bibliography checks — missing[bibliography]markers, unanchored entries, multi-anchor entries, unbalancednofetch(— negative-tested; the 36812–36819 register validates clean.Note:
unitsml-guide,unitsml-incorporation,unitsml-ubl-ndr-subsetare commented out ofmetanorma.yml— their 404s on the site are the intended build list, not truncation.Test plan
ruby scripts/validate-register.rb— VALIDATION OK (13 documents)metanorma compilespot-checks of fixed sections (full register compile happens in CI)