Repository navigation
Fix builder metadata copies and Number power checks - #101
Merged
Merged
Conversation
added 2 commits
November 5, 2026 16:36
Fluent #name, #quantity_reference and #multiplier now return a deep copy, so changing the result no longer changes the original formula. Unit.new, Dimension.new and the power_numerator setter reject a Number (or fenced Number) power that does not hold a number, instead of rendering it as m^abc and emitting a broken unit id. Dividing by a unit with power 0 keeps the power at 0 rather than writing -0.
State that composing further drops metadata (parsed comma metadata too), that an unknown quantity: is skipped rather than raised, that norm_text writes a square root as its exponent, and how to build a dimension quantity.
suleman-uzair
marked this pull request as ready for review
November 5, 2026 12:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three gaps in the composite unit builder and corrects the README where it described behaviour the code does not have.
Changes
#name,#quantity_referenceand#multiplierreturn a deep copy, so changing the result no longer changes the original formula.Unit.new,Dimension.newandpower_numerator=reject aUnitsml::Numberpower that does not hold a number (e.g.Number.new("abc")), including inside aFenced.0keeps the power at0instead of writing-0.quantity:leaves out<Quantity>,norm_textwrites a square root as its exponent, and a dimension quantity is built withUnitsml.compose(dimensions:).