Repository navigation
Invert dimensions after / in parsed and composed expressions - #102
Merged
Merged
Conversation
The parser inverted a unit after "/" but skipped a dimension, so dim_L/dim_T serialized as D_LT instead of D_LT-1. Dimensions now follow the same rule as units: inverse_power_numerator moves to the shared PowerNumerator storage and the parser applies it to both. Quantity arithmetic no longer keeps dimension leaves un-inverted on division, so Quantity(dim_L) / Quantity(dim_T) gives dim_L*dim_T^(-1). The two specs that pinned the old output now expect the inverted form.
suleman-uzair
changed the title
suleman-uzair
marked this pull request as ready for review
November 6, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the parser invert a dimension after
/, as it already does for a unit.dim_L/dim_Tserialized asD_LT(Time power1) instead ofD_LT-1. This restores the behaviour of asciimath2unitsml, whosepostprocess1inverts every term after/, dimensions included.Changes
Parser#update_units_exponentsapplies the same sqrt/inverse rule toUnitandDimension;inverse_power_numeratormoves to the sharedPowerNumeratormodule.Compose::Builderdrops theinvert_dimensions: falsepath, soQuantitydivision of dimension quantities givesdim_L*dim_T^(-1).Output change
dim_X/dim_Ynow serializes with the inverted power. The old output was wrong.