Skip to content

chore(main): release 4.37.8 - #2122

Merged
Eli Bosley (elibosley) merged 2 commits into
mainfrom
release-please--branches--main--components--unraid-monorepo
Oct 26, 2026
Merged

Eli Bosley (elibosley) merged 2 commits into
mainfrom
release-please--branches--main--components--unraid-monorepo

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

4.37.8 (2026-10-26)

Bug Fixes

  • api: preserve partial results and accurate notification counts (#2123) (3371fd4)
  • auth: limit repeated authorization requests (#2094) (e160a4e)
  • auth: prevent custom permission checks racing policy refresh (#2125) (05ba1bf)
  • graphql: bound request size and expanded selections (#2121) (0c60d9d)
  • graphql: filter schema metadata requests (#2095) (dcd396e)
  • settings: omit internal provider values (#2096) (30e8d6a)
  • updates: embed internal OS checks on Tools page (#2020) (b95ae92)
  • web: restore right-side banner fade on legacy headers (#2126) (da7b87d)

This PR was generated with Release Please. See documentation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T01:35:11.573031Z a677159 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c6a95b6-e254-40f0-bdb1-2e7eed893878

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot force-pushed the release-please--branches--main--components--unraid-monorepo branch 6 times, most recently from 112ccd6 to 31be60d Compare October 26, 2026 00:32
@github-actions

Copy link
Copy Markdown
Contributor Author

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.97%. Comparing base (7febc84) to head (bc59592).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2122   +/-   ##
=======================================
  Coverage   53.97%   53.97%           
=======================================
  Files        1046     1046           
  Lines       73610    73610           
  Branches     8835     8834    -1     
=======================================
  Hits        39730    39730           
  Misses      33752    33752           
  Partials      128      128           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
github-actions Bot force-pushed the release-please--branches--main--components--unraid-monorepo branch from 31be60d to 2950be2 Compare October 26, 2026 19:05
@github-actions

Copy link
Copy Markdown
Contributor Author

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

Eli Bosley (elibosley) added a commit that referenced this pull request Oct 26, 2026
## Summary
Make the notification load tests deterministic by delivering fixed event
batches to the real service handler after fixture writes complete.

## Why This Exists
Work intent: remove the filesystem-event cardinality assumption that
intermittently blocks API CI while preserving notification correctness
and read-cost coverage. Release PR #2122 failed [Test
API](https://github.com/unraid/api/actions/runs/40383834485/job/121796766331?pr=2122)
because 100 writes produced 157 change events. The test waited for
exactly 100 events and could never complete once the count exceeded that
value. Closing the watcher at a transient exact count could also discard
later deliveries.

## Resolution
Close the real watcher after initialization, then deliver the workload
through the existing `handleNotificationEvent` implementation. Keep real
fixture files, parsing, index updates, subscriptions, warning scans, and
all existing read-cost and final-state assertions. Add repeated-change
workloads at each history/burst size to verify duplicate changes
preserve exact counts and do not publish additions.

## Reviewer Considerations
This separates the fixed workload used to measure handler costs from OS
scheduling. The existing `notifications.overview.spec.ts` tests continue
to cover real watcher delivery, legacy writes, subscriptions, bursts,
hydration, and directory changes. The broadcast tests cover events
arriving during scans. Production notification behavior and timeout
limits are unchanged.

## Behavior Changes
CI no longer requires one filesystem event per logical file write. No
customer-facing or API behavior changes.

## Implementation Summary
One test file changes. The load matrix grows from 12 to 15 cases,
including duplicate change delivery. No production modules or
dependencies change.

## Verification
- Unchanged baseline: 12 load tests passed locally.
- Linux/Node 22/Chokidar 4.0.3 probe: 100 writes produced 200 change
events when paused between truncation and content writes; all 100 paths
were observed.
- `pnpm --filter @unraid/api test
src/unraid-api/graph/resolvers/notifications/notifications.load.spec.ts
src/unraid-api/graph/resolvers/notifications/notifications.overview.spec.ts
src/unraid-api/graph/resolvers/notifications/notifications.broadcast.spec.ts`:
45 passed.
- `pnpm --filter @unraid/api run lint`: passed.
- `pnpm --filter @unraid/api run type-check`: passed.

## Risk
The load test now measures an explicit event batch rather than OS
timing. Real watcher and in-flight broadcast integration coverage
remains in the adjacent suites. Full Linux CI is pending.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Tests**
* Expanded notification load-test coverage to include repeated changes
and verify expected event counts across change and creation operations.
* Load-test results now use a consistent handler workload rather than
relying on filesystem watcher delivery.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@github-actions

Copy link
Copy Markdown
Contributor Author

🚀 Storybook has been deployed to staging: https://unraid-ui-storybook-staging.unraid-workers.workers.dev

@github-actions

Copy link
Copy Markdown
Contributor Author

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR2122/dynamix.unraid.net.plg

@elibosley
Eli Bosley (elibosley) merged commit 9c45199 into main Oct 26, 2026
14 of 15 checks passed
@elibosley
Eli Bosley (elibosley) deleted the release-please--branches--main--components--unraid-monorepo branch October 26, 2026 20:15
@github-actions

Copy link
Copy Markdown
Contributor Author

🔄 PR Merged - Plugin Redirected to Staging

This PR has been merged and the preview plugin has been updated to redirect to the staging version.

For users testing this PR:

  • Your plugin will automatically update to the staging version on the next update check
  • The staging version includes all merged changes from this PR
  • No manual intervention required

Staging URL:

https://preview.dl.unraid.net/unraid-api/dynamix.unraid.net.plg

Thank you for testing! 🚀

@github-actions

Copy link
Copy Markdown
Contributor Author

🤖 Created releases:

🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant