Skip to content

test(api): make notification load event delivery deterministic #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eli Bosley (elibosley) merged 3 commits into from
Oct 26, 2026
Merged

test(api): make notification load event delivery deterministic #2127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05afdf4
chore(ai-review): record notification test forecast
elibosley Oct 26, 2026
6d11f3a
test(api): make notification load event delivery deterministic
elibosley Oct 26, 2026
f2ad094
chore(ai-review): record notification test review
elibosley Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .limetech/ai-review-markers/fix-notification-load-event-count-057e17c1ef19.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"disposition": "NOT_REQUIRED",
"forecast_commit": "05afdf4950007bf8d7ef88bc16ae7653bee35671",
"reviewed_sha": "6d11f3a14a28a9159340ab78d38422ca737820c6",
"schema": "limetech.ai-review-marker.v2",
"stage": "final",
"unresolved_proportionality_findings": []
}
49 changes: 32 additions & 17 deletions api/src/unraid-api/graph/resolvers/notifications/notifications.load.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ describe.sequential('Notification burst read costs', () => {
[1000, 24],
[1000, 100],
]) {
it.each(['create', 'change', 'delete', 'archive-only'] as const)(
`measures ${burstSize} %s events with ${historySize} unread and archived history files`,
it.each(['create', 'change', 'repeated-change', 'delete', 'archive-only'] as const)(
`measures ${burstSize} %s operations with ${historySize} unread and archived history files`,
async (operation) => {
basePath = await mkdtemp(join(tmpdir(), 'notification-load-'));
const path = (type: NotificationType, id: string) =>
Expand All @@ -59,7 +59,8 @@ describe.sequential('Notification burst read costs', () => {
);
}
const ids = Array.from({ length: burstSize }, (_, index) => `burst-${index}.notify`);
if (operation === 'change' || operation === 'delete') {
const changesExisting = operation === 'change' || operation === 'repeated-change';
if (changesExisting || operation === 'delete') {
await Promise.all(
ids.map(async (id) => {
await write(UNREAD, id);
Expand All @@ -73,6 +74,10 @@ describe.sequential('Notification burst read costs', () => {
);
await Reflect.get(service, 'initialization');
watcher = Reflect.get(NotificationsService, 'watcher');
// Measure a fixed handler workload. OS watchers can split or coalesce file writes.
// Real watcher delivery is covered by notifications.overview.spec.ts.
await watcher.close();
Reflect.set(NotificationsService, 'watcher', null);
const reads: string[] = [];
const events: { kind: string; path: string }[] = [];
const failures: unknown[] = [];
Expand All @@ -95,13 +100,10 @@ describe.sequential('Notification burst read costs', () => {
reads.push(file);
return load(file, type);
});
const handle = Reflect.get(service, 'handleNotificationEvent').bind(service);
Reflect.set(service, 'handleNotificationEvent', (file: string, kind: string) => {
events.push({ kind, path: file });
const pending = handle(file, kind).catch((error: unknown) => failures.push(error));
handlers.push(pending);
return pending;
});
const handle: (file: string, kind: string) => Promise<void> = Reflect.get(
service,
'handleNotificationEvent'
).bind(service);
const publish = Reflect.get(service, 'publishWarningsAndAlerts').bind(service);
Reflect.set(service, 'publishWarningsAndAlerts', () => {
const pending = publish();
Expand All @@ -128,24 +130,37 @@ describe.sequential('Notification burst read costs', () => {
case 'create':
await write(UNREAD, id, 'warning');
await copyFile(path(UNREAD, id), path(ARCHIVE, id));
events.push(
{ kind: 'add', path: path(UNREAD, id) },
{ kind: 'add', path: path(ARCHIVE, id) }
);
break;
case 'change':
case 'repeated-change':
await write(UNREAD, id, 'warning');
events.push({ kind: 'change', path: path(UNREAD, id) });
if (operation === 'repeated-change') {
events.push({ kind: 'change', path: path(UNREAD, id) });
}
break;
case 'delete':
await unlink(path(UNREAD, id));
events.push({ kind: 'unlink', path: path(UNREAD, id) });
break;
case 'archive-only':
await write(ARCHIVE, id, 'warning');
events.push({ kind: 'add', path: path(ARCHIVE, id) });
break;
}
})
);
const expectedEvents = burstSize * (operation === 'create' ? 2 : 1);
await vi.waitFor(() => expect(events).toHaveLength(expectedEvents), {
timeout: 15000,
});
await watcher.close();
const expectedEvents =
burstSize * (operation === 'create' || operation === 'repeated-change' ? 2 : 1);
for (const event of events) {
handlers.push(
handle(event.path, event.kind).catch((error: unknown) => failures.push(error))
);
}
await Promise.all(handlers);
await Promise.all(publications);
const elapsedMs = performance.now() - started;
Expand All @@ -172,7 +187,7 @@ describe.sequential('Notification burst read costs', () => {
expect(service.getOverview()).toMatchObject({
unread: {
total: unreadTotal,
warning: operation === 'create' || operation === 'change' ? burstSize : 0,
warning: operation === 'create' || changesExisting ? burstSize : 0,
},
archive: { total: archiveTotal, alert: operation === 'delete' ? burstSize : 0 },
});
Expand Down Expand Up @@ -210,7 +225,7 @@ describe.sequential('Notification burst read costs', () => {
operation,
historySize,
burstSize,
events: expectedEvents,
events: events.length,
fileReadAttempts: measuredReads.length,
warningScans: scans.mock.calls.length,
peakActiveScans,
Expand Down
Loading