cmp: honor the byte limit in quiet size checks - #296
Open
SichenLiang wants to merge 1 commit into
Open
SichenLiang wants to merge 1 commit into
SichenLiang wants to merge 1 commit into
Conversation
Use the quiet-mode size shortcut only for two regular files, with no skipped bytes, when the comparison limit extends beyond the shorter file. Otherwise, read the requested data as needed before deciding the result. This fixes byte-limited comparisons and gives GNU-compatible status in the tested directory and /dev/zero cases. One difference remains: `cmp -s a dir` now returns 2, but quiet mode still omits GNU's "Is a directory" diagnostic. New tests cover byte limits, skipped bytes, devices, directories, and `-i 0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the quiet-mode size shortcut only for two regular files, with no skipped bytes, when the comparison limit extends beyond the shorter file. Otherwise, read the requested data as needed before deciding the result.
This fixes byte-limited comparisons and gives GNU-compatible status in the tested directory and
/dev/zerocases. One difference remains:cmp -s a dirnow returns 2, but quiet mode still omits GNU'sIs a directorydiagnostic.New tests cover byte limits, skipped bytes, devices, directories, and
-i 0.Fixes #295