Repository navigation
Update core dependencies in pyproject.toml to use version floors inst… - #225
Conversation
…ead of pins, ensuring compatibility with the oldest versions that pass the test suite. Add a new CI job to test against the lowest core dependencies. Bump version to 0.9.3 in version.py.
There was a problem hiding this comment.
Devin Review found 2 potential issues.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| # Core first at their floors; the extras and test tools then install | ||
| # around them without upgrading what is already satisfied. | ||
| uv pip install --system --resolution lowest-direct -e . | ||
| uv pip install --system -e '.[test,all]' |
There was a problem hiding this comment.
🟡 Core dependency floors can escape testing
When an extra requires a newer core package, uv pip install can replace the version selected by lowest-direct. The job then passes without testing that core package at its declared floor.
Learn more
The lowest-dependencies job first resolves the core project using --resolution lowest-direct, then runs a separate installation with every extra and the test tools. That second installation resolves a new requirement set and does not pin or check the versions installed by the first step. If any extra or its transitives need a newer core package, the tests exercise the replacement instead of the declared floor, even though the job succeeds.
Example: Suppose the first install selects pydantic 2.9 and an optional dependency requires pydantic >=2.10. The second install replaces 2.9 with 2.10; make test runs against 2.10 and reports success without checking 2.9.
Recommended fix: Capture the selected core versions from the first install and constrain the extras installation to those versions, or install the full test requirement set once with explicit core floor constraints. Fail the job if any core version differs before running tests.
Was this helpful? React with 👍 or 👎 to provide feedback.
| test-lowest: | ||
| # Guards the floors in pyproject.toml: core dependencies resolve to the | ||
| # oldest versions allowed, on the oldest supported Python. | ||
| name: Test (lowest core dependencies) |
There was a problem hiding this comment.
🟡 Broken dependency floors can reach publication
When test-lowest fails after a version bump, publication can still proceed. The publish job depends only on its separate test job.
Learn more
Main CI and Python Publish are separate workflows triggered on the same push. The publish job waits only for the test job inside Python Publish, not for the new lowest-dependencies check. A failure in the new check therefore cannot prevent publishing that commit if the publish workflow's normal tests pass.
Example: A version bump passes Python Publish's Python 3.10 tests but fails test-lowest on an allowed older dependency. Python Publish still tags and uploads the version.
Recommended fix: Make the publishing workflow run or explicitly wait for the lowest-dependencies check before tagging and uploading, or enforce a branch protection requirement that the lowest-dependencies check passes before the version bump reaches main.
Was this helpful? React with 👍 or 👎 to provide feedback.
…ions for NOUL questions. Update test cases to utilize predefined NOUL constants for consistency and clarity. Ensure all relevant tests reflect the new structure, improving maintainability and readability.
…ead of pins, ensuring compatibility with the oldest versions that pass the test suite. Add a new CI job to test against the lowest core dependencies. Bump version to 0.9.3 in version.py.