Skip to content

Update core dependencies in pyproject.toml to use version floors inst… - #225

Merged
shahrear33 merged 2 commits into
mainfrom
sh/version-pin
Nov 3, 2026
Merged

shahrear33 merged 2 commits into
mainfrom
sh/version-pin

Conversation

@shahrear33

@shahrear33 shahrear33 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

…ead of pins, ensuring compatibility with the oldest versions that pass the test suite. Add a new CI job to test against the lowest core dependencies. Bump version to 0.9.3 in version.py.


Devin Review

…ead of pins, ensuring compatibility with the oldest versions that pass the test suite. Add a new CI job to test against the lowest core dependencies. Bump version to 0.9.3 in version.py.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)

Devin Review

Comment thread .github/workflows/ci.yml
# Core first at their floors; the extras and test tools then install
# around them without upgrading what is already satisfied.
uv pip install --system --resolution lowest-direct -e .
uv pip install --system -e '.[test,all]'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Core dependency floors can escape testing

When an extra requires a newer core package, uv pip install can replace the version selected by lowest-direct. The job then passes without testing that core package at its declared floor.

Learn more

The lowest-dependencies job first resolves the core project using --resolution lowest-direct, then runs a separate installation with every extra and the test tools. That second installation resolves a new requirement set and does not pin or check the versions installed by the first step. If any extra or its transitives need a newer core package, the tests exercise the replacement instead of the declared floor, even though the job succeeds.

Example: Suppose the first install selects pydantic 2.9 and an optional dependency requires pydantic >=2.10. The second install replaces 2.9 with 2.10; make test runs against 2.10 and reports success without checking 2.9.

Recommended fix: Capture the selected core versions from the first install and constrain the extras installation to those versions, or install the full test requirement set once with explicit core floor constraints. Fail the job if any core version differs before running tests.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread .github/workflows/ci.yml
Comment on lines +60 to +63
test-lowest:
# Guards the floors in pyproject.toml: core dependencies resolve to the
# oldest versions allowed, on the oldest supported Python.
name: Test (lowest core dependencies)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Broken dependency floors can reach publication

When test-lowest fails after a version bump, publication can still proceed. The publish job depends only on its separate test job.

Learn more

Main CI and Python Publish are separate workflows triggered on the same push. The publish job waits only for the test job inside Python Publish, not for the new lowest-dependencies check. A failure in the new check therefore cannot prevent publishing that commit if the publish workflow's normal tests pass.

Example: A version bump passes Python Publish's Python 3.10 tests but fails test-lowest on an allowed older dependency. Python Publish still tags and uploads the version.

Recommended fix: Make the publishing workflow run or explicitly wait for the lowest-dependencies check before tagging and uploading, or enforce a branch protection requirement that the lowest-dependencies check passes before the version bump reaches main.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

…ions for NOUL questions. Update test cases to utilize predefined NOUL constants for consistency and clarity. Ensure all relevant tests reflect the new structure, improving maintainability and readability.
@shahrear33
shahrear33 requested a review from spillai November 3, 2026 21:48
@shahrear33
shahrear33 merged commit 8a90186 into main Nov 3, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
dev — fbead939 Deployed Nov 3, 2026 by shahrear33 via Test (3.13) #658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant