feat(python): support integer column indices in read_url projection - #10287
Open
jackylee-ch wants to merge 2 commits into
Open
jackylee-ch wants to merge 2 commits into
jackylee-ch wants to merge 2 commits into
Conversation
`read_url`'s docstring and type stub both document `projection` as
`list[str | int]` ("by their index or name"), but the implementation only
accepted strings and raised `TypeError` on an integer, so the documented
positional form never worked.
Map an integer to the top-level field name at the matching position (threading
the file dtype into `projection_from_python`), erroring on an out-of-range index
or a non-struct file. String projection is unchanged.
Signed-off-by: jackylee-ch <[email protected]>
robert3005
reviewed
Oct 4, 2026
Replace the manual isinstance branching in projection_from_python with a FromPyObject-derived `ProjectionColumn` enum, as suggested in review. Signed-off-by: jackylee-ch <[email protected]>
robert3005
approved these changes
Oct 4, 2026
robert3005
enabled auto-merge (squash)
October 4, 2026 20:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
read_url's docstring and.pyistub both documentprojectionaslist[str | int]("identified either by their index or name"), butprojection_from_pythononly accepted strings and raisedTypeErroron aninteger — so
read_url(url, projection=[0, 2])crashed despite being thedocumented, type-checked form.
Fix
Map an integer to the top-level field name at the matching position (threading
the file dtype into
projection_from_python), erroring on an out-of-range indexor a non-struct file. String projection is unchanged. Scoped to
read_url/VortexDataset, which is where int projection is documented.AI assistance
Prepared with AI assistance; I have reviewed and verified the change.