Repository navigation
Audit tests for duplication and coverage - #10458
robert3005 wants to merge 2 commits into
Conversation
70a4472 to
25ba6a5
Compare
Merging this PR will degrade performance by 13.94%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | density_sweep_dense_runs[0.001] |
29.6 µs | 47 µs | -37.06% |
| ❌ | WallTime | bitpack_blocked_compress_avx512 |
4.8 µs | 5.6 µs | -14.06% |
| ❌ | WallTime | starts_with_avx2[8, VarBin] |
41.2 µs | 46.6 µs | -11.68% |
| ❌ | WallTime | bitpack_blocked_compress_avx2 |
6.7 µs | 7.6 µs | -11.25% |
| ⚡ | WallTime | words_gather_dispatch_neon[65536] |
2.3 µs | 2 µs | +11.34% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/removeredundanttests (97041d3) with develop (58d0490)
fix the assertions that have been found by test audit extracted from #10458 --------- Signed-off-by: Robert Kruszewski <[email protected]>
25ba6a5 to
a95bf52
Compare
Signed-off-by: Robert Kruszewski <[email protected]>
Signed-off-by: Robert Kruszewski <[email protected]>
4781ae4 to
97041d3
Compare
Some of the tests covered duplicate logic, they haven't been updated to latest helper functions or simply didn't check the correct thing. This should have audited all of the tests we have in the repo and fix them without losing coverage