Repository navigation
fix: a vp09 track plays, where createPlayer asked for no VP9 decoder and the item had a picture of no size - #128
Merged
Conversation
…and the item had a picture of no size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VP9 is one of VideoToolbox's supplemental decoders, which a process has to ask for before AVFoundation can use one. Without
VTRegisterSupplementalVideoDecoderIfAvailable, avp09track in an MP4 opens and comes ready with a picture of no size, hands out no frames, and no error says why.isPlayableExtendedMIMETypeanswers false for the same type until the process asks.createPlayernow asks, once. A Mac with no such decoder is told nothing new: its VP9 fails as any format it cannot play does.This is what lets
<Html>in react-x11-components play a scroll-scrubbed VP9 clip on the system's decoder, rewrapped from the WebM a page appends. On an M-series Mac, 2160x2252 at 60 fps scrubbed forward at a median of 9.2 ms a seek and backward at 16.7 ms, every frame delivered, throughAVPlayerItemVideoOutput.test/player-vp9.jsplays a 160x90 VP9 fixture. It passes with this change and fails on the released 0.30.1 withthe item never came ready. On CI a machine with no decoder passes with a note, since a virtual Mac may have none.Released as a patch, react-x11's
^0.30.1picks this up with no change there.