Repository navigation
Support Laravel 12 - #207
LukeTowers wants to merge 215 commits into
Conversation
Release v1.2.1
Co-authored-by: Luke Towers <[email protected]>
Co-authored-by: Wim Verhoogt <[email protected]> Co-authored-by: Ben Thomson <[email protected]>
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
…sh-prone rebuild (#239) Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
Builds on the Laravel 12 work (wintercms#207). Bumps to laravel/framework ^13, PHP ^8.3, tinker ^3, carbon ^3.8.4, symfony ^7.4|^8.0, testbench ^11 (PHPUnit kept at ^11.5.50 pending phpunit 12 support in test helpers). Code: defer ArraySource datasource setup out of the model boot cycle (L13 forbids instantiating a model while booting); restate Builder<Model> param on HasRelationships relation factories; fix Preferences::findRecord() scope typing; drop the unsupported 2nd arg to DownCommand option('status'); update schedule:list invokable-class test expectation; prune stale phpstan baseline entries; CI matrices to PHP 8.3/8.4.
# Conflicts: # composer.json
austinderrick
left a comment
There was a problem hiding this comment.
Adding an approval flag from me because I've tested this quite extensively on our 1.3 deploys.
|
@LukeTowers @bennothommo CodeRabbit is right, why are we breaking the method signature here? |
Co-authored-by: mjauvin <[email protected]>
|
@LukeTowers any idea why this isn't working anymore ? |
Agreed, stripping the extra quotes is needed: some databases report a column's default as a quoted SQL literal, so a default copied back from Your Here's your current override run on Laravel 12.69.3, next to the same override with the inner quotes unescaped as well:
Suggested change, which keeps your tests passing: $value = str_replace("''", "'", substr($value, 1, -1));and a test case with I checked that SQLite's 🤖 Generated with Claude Code |
Co-authored-by: Claude Opus 5.5 <[email protected]>
Replaces #173, continuing the work done by @mjauvin @bennothommo & @wverhoogt
Summary by CodeRabbit
New Features
Bug Fixes