Repository navigation
tests: send the highwater IGNORE unkeyed - #1304
Merged
Merged
Conversation
Strict KEX is on by default, and wolfSSH_SendIgnore() refuses an unkeyed send under it. The HighwaterQuietAfterBadPacket test session is never keyed, so it turns strict KEX off on its CTX before the session exists and the final send reaches HighwaterCheck() again.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change correctly restores the test’s intended execution path.
0 open findings
What changed in this PR
Fixes HighwaterQuietAfterBadPacket so its unkeyed IGNORE packet reaches the intended highwater check.
Changes:
- Disables strict KEX for the test context.
- Documents why the test requires this exception.
| File | Description |
|---|---|
tests/unit.c |
Allows the unkeyed test send to proceed. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1304
Scan targets checked: wolfssh-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
philljj
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master fails
tests/unit.testonHighwaterQuietAfterBadPacket. The test landed in PR 1279, which last ran CI before strict KEX (PR 1271) was merged. Strict KEX is on by default and makeswolfSSH_SendIgnore()refuse an unkeyed send, and the test session is never keyed.wolfSSH_SendPacket()and the highwater check.