[dkarten]

Stacks on #177.

Summary

• Adds POST /data-integrations/{slug}/credentials. It returns the account's token as a credential. Without a usable account it returns { active: false, error } with not_installed or needs_reauthorization.
• connection_owner: organization vends the organization's account and requires organization_id. user, the default, vends the user's own.
• A user who is not an active member of the organization gets a 403, for either owner.
• A malformed body gets the spec's 400 { message, error: 'Bad Request' }.
• /credentials and /token share the token logic (vendAccessToken).

Behaviour

Request	Outcome
/credentials with a malformed body	400, "error": "Bad Request"
/credentials naming an organization the user is not an active member of	403
/credentials resolving a personal account scoped to an organization the user is not an active member of	403
/credentials with no account for the owner	200, { "active": false, "error": "not_installed" }

Verification

Full suite: 1918 pass, 0 fail. bun run typecheck, bun run lint, bun run fmt:check and bun run gen:supported are clean. New tests in data-integrations.spec.ts cover both owners, the reauthorization and disconnect states, both 403s, each malformed body, and the user-owned path through the Node SDK's createDataIntegrationCredential.

Resolves part of #176

[greptile-apps]

Confidence Score: 5/5

[Critical impact] The PR appears safe to merge, with one remaining non-blocking error-response mismatch.

Findings

1.  Invalid JSON gets different fields ▶

Fix with agent prompt

### Issue 1
src/workos/routes/data-integrations.ts:undefined-95
Invalid JSON sent to `/credentials` bypasses `badRequest()`. For example, a body of `{` returns `{ message: 'Problems parsing JSON', code: 'invalid_request_body' }`, rather than the documented `{ message, error: 'Bad Request' }`. Convert parsing failures to this route's error shape and add an invalid-JSON test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds credential retrieval for user- and organization-owned connected accounts.

• Organizations can manage their own connected accounts.
• Credential requests return a connected account's token for either owner.
• Seed files can create organization-owned connected accounts.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[POST credentials] --> B[Check user and named organization]
  B --> C{Account owner}
  C -->|User| D[Find user's account]
  C -->|Organization| E[Find organization's account]
  D --> F{Account found?}
  E --> F
  F -->|No| G[Return not_installed]
  F -->|Yes| H[Check membership when organization-scoped]
  H --> I[vendAccessToken]
  I --> J[Return credential or needs_reauthorization]

Loading

_{Reviews (2) · Last reviewed commit: "fix(pipes): assert the vended value in t..." · Reviewed by Greptile}

[greptile-apps]

Invalid JSON gets different fields

Invalid JSON sent to /credentials bypasses badRequest(). For example, a body of { returns { message: 'Problems parsing JSON', code: 'invalid_request_body' }, rather than the documented { message, error: 'Bad Request' }. Convert parsing failures to this route's error shape and add an invalid-JSON test.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/workos/routes/data-integrations.ts
Line: 95

Comment:
**Invalid JSON gets different fields**

Invalid JSON sent to `/credentials` bypasses `badRequest()`. For example, a body of `{` returns `{ message: 'Problems parsing JSON', code: 'invalid_request_body' }`, rather than the documented `{ message, error: 'Bad Request' }`. Convert parsing failures to this route's error shape and add an invalid-JSON test.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[dkarten]

We're following the convention of other existing endpoints here. Leaving for now.

[greptile-apps]

Understood. Keeping parseJsonBody behavior consistent with the existing endpoints is reasonable; I’ll treat this as intentional and won’t press the finding.