Repository navigation
chore: share one .editorconfig across plugins - #843
Open
josephfusco wants to merge 1 commit into
Open
josephfusco wants to merge 1 commit into
josephfusco wants to merge 1 commit into
Conversation
The five plugin copies came in two variants. plugins/.editorconfig keeps the fuller one, which also sets 2-space YAML (the other variant tab-indented YAML, which YAML doesn't allow). EditorConfig applies it to every plugin folder without a build step.
|
Contributor
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (37)📁 examples/hwp-preview-rest/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/uploads.zip (1 error)
📁 examples/hwp-preview-rest/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-rest/.wp-env.json (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-wpgraphql/wp-env/__MACOSX/._uploads (1 error)
📁 examples/hwp-preview-wpgraphql/.wp-env.json (1 error)
📁 examples/hwp-preview-astro/wp-env/setup/.htaccess (1 error)
📁 examples/hwp-preview-astro/.wp-env.json (1 error)
📁 .env.dist (2 errors)
📁 docs/.gitkeep (1 error)
📁 .docker/.env.ci (1 error)
📁 .wp-env.json (1 error)
📁 phpstan.neon.dist (1 error)
📁 bin/build-docker.sh (1 error)
📁 bin/_lib.sh (1 error)
📁 bin/sync-package-version.sh (1 error)
📁 bin/run-codeception.sh (1 error)
📁 bin/install-plugins.sh (1 error)
📁 bin/install-test-env.sh (1 error)
📁 bin/local/run-e2e-tests.sh (1 error)
📁 bin/local/setup-docker-env.sh (1 error)
📁 bin/local/run-qa.sh (1 error)
📁 bin/local/run-unit-tests.sh (1 error)
📁 .docker/init-docker.sh (1 error)
📁 examples/hwp-preview-wpgraphql/example-app/src/pages/[identifier].js (1 error)
📁 examples/hwp-preview-astro/example-app/src/pages/[...uri].astro (1 error)
📁 hwp-previews.php (3 errors)
📁 readme.txt (2 errors)
📁 activation.php (1 error)
📁 deactivation.php (1 error)
📁 src/Templates/admin.php (1 error)
📁 src/Templates/iframe.php (1 error)
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the five per-plugin
.editorconfigfiles with one atplugins/.editorconfig. Editors look for.editorconfigin parent folders, so every plugin, and hwp-cli, which had none, picks it up. Nothing is generated or copied.Which settings
The copies came in two variants:
.txtfiles.The shared file uses the second variant. No plugin YAML file is tab-indented today, so it matches how the files are already written.
Scope
It lives in
plugins/, not the repo root, so the example apps underexamples/andpackages/keep their own styles. Each plugin's old.editorconfigwas alreadyroot = trueand covered its ownexamples/folder, so nothing inside the plugins changes scope. Zips don't change either, because.editorconfigis excluded from them.Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with consolidating duplicated editor config.