Repository navigation
refactor: simpler review config rules - #26
Merged
MauroToscano merged 1 commit intoNov 17, 2026
Merged
Conversation
Each changed file is now handled by the first rule that matches: always_review (reviewed as code), ignore, the built-in skips (lockfiles, binaries, generated and vendored code, whitespace-only changes, docs), tests, and everything else gets every reviewer. A part made only of low_risk code gets low_risk_lanes (default gpt, kimi, glm) in any PR, split or not, unless triage promotes it. Large PRs are reviewed in path order, low-risk parts last; `continue budget=N` reviews what the budget did not reach. Removed: sensitive, default_sensitive, priority (and its double budget), nonsensitive_lanes (now low_risk_lanes) and unit_depth. A config that still uses one of them is refused with what replaces it.
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the repository config of the multi-model review (#24). This targets #24's branch, like #25.
Rules
Each changed file is handled by the first rule that matches:
always_review: reviewed as code, whatever the rules below say (binary files and whitespace-only changes excepted). For text that drives behaviour, such as model prompts.ignore: not reviewed.test_globs): reviewers get the test file names and the test functions they change, not the diff.A part made only of
low_riskcode getslow_risk_lanes(defaultgpt,kimi,glm), in any PR, split or not, unless the cheap triage call finds that it touches keys, auth, funds, cryptography or untrusted input. Large PRs are reviewed in path order, low-risk parts last. If the budget runs out, the comment lists the rest and<command> continue budget=Nreviews them.threat_modelthreat_model.mdignoretest_globsalways_reviewlow_risklow_risk_lanesgpt,kimi,glmRemoved
sensitiveanddefault_sensitive: with the default,sensitiveonly set the review order. Its one other effect, reviewing listed Markdown files as code, is nowalways_review.priorityand the double per-reviewer budget for priority parts: the order only matters when a PR can't finish within its budget, and thencontinuereviews the rest. This also removes the mismatch where Opus was told 80 commands on a priority part while its limit allowed 160.nonsensitive_lanes: renamed tolow_risk_lanes. The default changes fromclaude, gpt, kimitogpt, kimi, glm: Opus alone costs more than those three together (Nov 13 runs: Opus $1.60, GPT $0.36, Kimi $0.34, GLM $0.40 per PR).unit_depth: fixed at 2.The runner refuses a config that still uses a removed key and says what replaces it, so an old config can't silently stop doing what it says.
Other changes
sensitiveandpriority.ai-review/prompts/**,.github/prompts/**and.github/ai-review/**inalways_review.Callers
yetanotherco/lambda_vm#1032 pins b265aff, which still accepts the old keys. Its config needs the new keys before it is re-pinned to a commit with this change; so does yetanotherco/waas#198.
Tests
24 offline tests pass (7 new):
always_reviewbeats ignore, lockfile, generated, docs and test rules, but not binary or whitespace-only files;low_risk_laneswhether the PR is split or not;I also rendered the report's coverage and "who reviewed what" tables for a split PR with a low-risk part and a triage promotion. Nothing ran against a model.