Repository navigation
Store username of access token - #378
Merged
Merged
Conversation
Token validation already requests 'users/me', so keep the username from the response and expose it as 'ServerAPI.access_token_username'. Use it in 'login' and 'init_service' instead of refetching the user. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Connection keeps the username of the access token owner, available as
ServerAPI.access_token_username. It does not need an additional request.Additional info
Token validation already requests
users/mebut used only the status code, so the user was fetched again whenever the username was needed.login, and cleared when the token is reset.as_username. Useget_userto get the user requests are made as.loginandinit_serviceuse the new property instead ofget_user.Testing notes:
con.access_token_usernamereturns the same name ascon.get_user()["name"]without an additional request.con.reset_token()makes it returnNone.