Repository navigation
Conversation
`Path.copy()` can raise `PermissionError` when a sandbox denies the `FICLONE` ioctl, even when an ordinary copy is permitted. A file that does not support the ioctl can also return `ENOTTY`. Try the next copy method when `FICLONE` fails with `EPERM`, `EACCES`, or `ENOTTY`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.copy()can fail on a readable file when the build exposesfcntl.FICLONEbut the process cannot use it. Android’s SELinux policy denied the ioctl withEACCES, prompting CPython to hide the constant on Android (see python#122522). DVC encounteredENOTTYfrom the same ioctl on an ext4 filesystem (see treeverse/dvc#6980) and added a fallback (see treeverse/dvc-objects#120).A seccomp policy can also deny the ioctl with
EPERMwhile allowing an ordinary copy. Try the next copy method when the clone ioctl fails withEACCES,EPERM, orENOTTY. This extends the per-operation fallback inPath.copy()(see python#122897) and matches GNUcp --reflink=autofor these errors (see https://github.com/coreutils/coreutils/blob/3a1595e2afe6e91fc534884a385e7e57d1a54c4d/src/copy.c#L675-L690). An I/O failure such asEIOstill propagates.