Repository navigation
Deprecate Sequent.configuration.time_precision in favour of ActiveSupport's - #560
Closed
erikrozendaal wants to merge 1 commit into
Closed
erikrozendaal wants to merge 1 commit into
erikrozendaal wants to merge 1 commit into
Conversation
…port's The precision of the times in the JSON of events and commands is that of ActiveSupport::JSON::Encoding.time_precision, which Oj follows in rails mode. Sequent's time_precision was a copy of it taken when Sequent was loaded, which only ParamSupport used, so setting it, or changing ActiveSupport's precision later, made the two differ. Reading it now returns ActiveSupport's precision, and setting it has no effect, both with a deprecation warning.
Member
Author
|
Replaced by #562: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequent's
time_precisionlooked like it set the precision of times, but the JSON of events and commands always usesActiveSupport::JSON::Encoding.time_precision, which Oj follows in rails mode. Sequent's setting was a copy of ActiveSupport's precision taken when Sequent was loaded, so setting it, or changing ActiveSupport's precision afterwards, made code that relied on it, likeParamSupport, disagree with the stored JSON.Reading the setting now returns ActiveSupport's precision and setting it has no effect, both with a deprecation warning, so there is one precision that matters. Setting it deliberately does not change ActiveSupport's precision, since that would change the JSON of the whole application, including newly stored events.