feat(failures): show passing groups and an empty state by lewisjared · Pull Request #159 · Climate-REF/ref-app

lewisjared · 2026-10-25T11:06:33Z

Adds a "Show passing groups" toggle to the failures page, and lists models without failures in the model picker so a model like ACCESS-ESM1-6 can be picked. When nothing matching the filters is failing, the page shows an empty state with how many groups passed and a button to show them.

Each diagnostic card lists its passing groups 25 at a time, fetched only once the section is expanded.
The toggle is kept in the URL as passing=true, alongside the existing model, era, reason and day filters.
/executions/ gains exact provider_slug and diagnostic_slug filters, because the _contains filters can match other diagnostics (annual-cycle matches regional-historical-annual-cycle).
The reason and day filters describe failures, so they do not narrow the passing groups.

The screenshots use the production API, which lacks the new slug filters, so the expanded list there includes another diagnostic's groups (the g118 keys belong to enso-characteristics).

Adds a "Show passing groups" toggle that lists each diagnostic's passing execution groups, loaded on expand. Models without failures now appear in the model picker, so picking one shows an empty state with how many of its groups passed. The executions list gains exact provider_slug and diagnostic_slug filters for this.

coderabbitai · 2026-10-25T11:06:52Z

Walkthrough

The execution-groups API and generated client now support exact provider and diagnostic slug filters. The failures page adds a passing-groups view, includes models without failures in its counts, and shows aggregate success totals and links to passing execution groups.

Changes: Execution failures and passing groups

Layer / File(s)	Summary
Exact-slug execution-group filters `backend/src/ref_backend/api/routes/executions.py`, `backend/tests/test_api/test_routes/test_executions.py`, `frontend/src/client/*`	The route accepts provider and diagnostic slug filters, and the test checks exact slug matching. Generated client types and documentation include these filters. Generated metric-value documentation now lists `scalar` and `series` as options.
Failure-page filters and model counts `frontend/src/components/failures/failureFilters.tsx`, `frontend/src/components/failures/useFailures.ts`, `frontend/src/lib/failures.ts`, `frontend/src/lib/failures.test.ts`, `frontend/src/routes/_app/executions.failures.tsx`	The failures page adds a passing-mode search parameter and checkbox. Model counts include models without failures. Helpers calculate aggregate totals and tests cover the helper results.
Passing-group results and empty states `frontend/src/components/failures/{diagnosticFailuresCard,failuresEmptyState,openGroupLink,passingGroups}.tsx`, `frontend/src/routes/_app/executions.failures.tsx`, `changelog/159.feature.md`	The page displays passing diagnostics in passing mode. Diagnostic cards can show paginated passing groups. Empty states can show group totals and offer the passing view.

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant FailuresPage
  participant DiagnosticFailuresCard
  participant PassingGroups
  participant list_recent_execution_groups
  participant ExecutionGroupFilter
  User->>FailuresPage: Select passing mode
  FailuresPage->>DiagnosticFailuresCard: Pass the selected era
  DiagnosticFailuresCard->>PassingGroups: Render the passing-group list
  PassingGroups->>list_recent_execution_groups: Request groups with provider and diagnostic slugs
  list_recent_execution_groups->>ExecutionGroupFilter: Pass slug and success filters
  ExecutionGroupFilter-->>list_recent_execution_groups: Return matching groups
  list_recent_execution_groups-->>PassingGroups: Return execution groups

Possibly related PRs

Climate-REF/ref-app#147: Introduced the execution-group filter and loader that this change extends with provider and diagnostic slug filters.

Priority: Normal

Change: Feature

Merge Risk: Low · up to 82754

These errors can temporarily hide passing groups or models without failures. Both are recoverable, so the change is mergeable with follow-up error handling.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 70.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 14 files. (1 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main changes: showing passing groups and adding an empty state on the failures page.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 70.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 17 functions across 14 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4b52022f-b35b-44fa-a086-494380c9b46b

Commits

Reviewing files that changed from the base of the PR and between 7bd72c1 and 8275468.

Files selected for processing: 15

backend/src/ref_backend/api/routes/executions.py
backend/tests/test_api/test_routes/test_executions.py
changelog/159.feature.md
frontend/src/client/@tanstack/react-query.gen.ts
frontend/src/client/sdk.gen.ts
frontend/src/client/types.gen.ts
frontend/src/components/failures/diagnosticFailuresCard.tsx
frontend/src/components/failures/failureFilters.tsx
frontend/src/components/failures/failuresEmptyState.tsx
frontend/src/components/failures/openGroupLink.tsx
frontend/src/components/failures/passingGroups.tsx
frontend/src/components/failures/useFailures.ts
frontend/src/lib/failures.test.ts
frontend/src/lib/failures.ts
frontend/src/routes/_app/executions.failures.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

coderabbitai · 2026-10-25T11:16:33Z

+  if (error) {
+    return <p className="text-sm text-destructive">{apiErrorMessage(error)}</p>;
+  }


Minor · Stability & Availability · Quick win

Keep loaded groups visible when a later page fails.

If “Load More” fails, the infinite query can report a next-page error while retaining earlier pages. This early return hides those pages and removes the pagination control. Show the error beside the loaded groups and let the user retry the failed page. Reserve the full-list error state for a failed initial load. (tanstack.com)

coderabbitai · 2026-10-25T11:16:33Z

+  const models = useQuery({
+    ...modelsListOptions({ query: { mip_era: mipEra } }),
+    staleTime: 5 * 60 * 1000,
+  });


Minor · Functional Correctness · Quick win

🔎 Supported by static analysis

Script executed:

sed -n '57,85p' frontend/src/components/failures/useFailures.ts sed -n '100,115p' frontend/src/routes/_app/executions.failures.tsx rg -n 'refetchOnWindowFocus|retry:|QueryClient|queryClient' frontend/src

Repository: Climate-REF/ref-app

Length of output: 7160

Script executed:

sed -n '45,68p' frontend/src/main.tsx sed -n '1,120p' frontend/src/components/failures/useFailures.ts rg -n -F --glob '*.tsx' -e 'modelCounts' -e 'modelOptions' -e 'selectedModel' -e 'models' frontend/src/routes/_app/executions.failures.tsx frontend/src/components/failures sed -n '115,230p' frontend/src/routes/_app/executions.failures.tsx sed -n '1,110p' frontend/src/routes/_app/executions.failures.tsx rg -n -F --glob '*.ts' --glob '*.tsx' -e 'retryUnlessNotFound' -e 'refetchOnWindowFocus' -e 'refetchOnReconnect' frontend/src

Repository: Climate-REF/ref-app

Length of output: 13162

Handle the failed models query as a recoverable picker error.

When modelsListOptions exhausts its retries, models.data remains unavailable and withModelsWithoutFailures omits models with no failures. The catalogue and unsuccessful execution results remain usable. A page reload or normal React Query refetch can recover the models query.

Add models to the page error and retry handling without hiding the loaded failure results.

Suggested fix

- const failed = [catalog, unsuccessful].filter( + const failed = [catalog, unsuccessful, models].filter(

fix(failures): error paths from #159 and updating dots

lewisjared added 2 commits October 25, 2026 22:06

docs(changelog): add 159 fragment

8275468

coderabbitai Bot requested changes Oct 25, 2026

View reviewed changes

lewisjared merged commit 6a4d7dd into main Oct 25, 2026
6 checks passed

lewisjared deleted the feat/failures-empty-state branch October 25, 2026 22:45

lewisjared mentioned this pull request Oct 25, 2026

fix(failures): error paths from #159 and updating dots #161

Merged

lewisjared added a commit that referenced this pull request Oct 25, 2026

Merge pull request #161 from Climate-REF/fix/failures-review-follow-up

9c480e5

fix(failures): error paths from #159 and updating dots

Navigation Menu

Repository navigation

feat(failures): show passing groups and an empty state - #159

feat(failures): show passing groups and an empty state#159
lewisjared merged 2 commits into
mainfrom
feat/failures-empty-state

lewisjared commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Uh oh!

coderabbitai Bot Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lewisjared commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Oct 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lewisjared commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading