Repository navigation
Conversation
…force scan cancel gates
imol-ai
requested changes
Nov 15, 2026
imol-ai
left a comment
Member
There was a problem hiding this comment.
- don't remove the code for scanning all log pages please, it might come in handy later
- don't change the behaviour of the post gift reconciliation logscan - no cancel button, and must execute on cancelled gifts aswell; only add a cancel to the general logscan
…conomy dedup window
…d scope cancel to /eden logscan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EconomyMessageFilter.parse(...)(reusing thehideEconomyMessagesmatching/normalization logic) and relay matched lines viaBridgeWebSocketClient.sendGuildEconomy(text, seq)keyed withOccurrenceSequencer(gated byOutboundPolicy, guild-only). InClientPacketListenerMixin, still invokemod.handleSystemChat(...)before cancelling hidden economy lines so chat filtering does not drop events.GuildLogSync.scanWholeLogto the General category (FULL_SCAN_TOTAL_PAGES = 5instead of 30) and removeGuildLogEvent.Text,KNOWN_FILTERS, header filter selection, andGuildLogTextCategoryTest./eden logscanand post-gift scans (GiftProgressScreenwired toguildLogSync::requestCancel/postRunLogScanCancel), abortGuildLogSyncwaits cleanly when cancelled without recordinglastScanFinishedAt, preventpostRunLogScanfrom running unless the gift/payout completed uncancelled and unaborted with confirmed units, and resetcancelRequestedcleanly on subsequent runs/scans.EconomyMessageFilterTest,GuildLogFilterButtonTest, andOutboundPolicyTest("guildEconomy"inGUILD_ONLY).Verification
.\gradlew.bat test build:BUILD SUCCESSFUL(474tests total:470passed,4skipped,0failed;:spotlessCheckand:checkpassed)