Repository navigation
script: reject malformed script integers, add tests - #549
Open
jgriffiths wants to merge 20 commits into
Open
jgriffiths wants to merge 20 commits into
jgriffiths wants to merge 20 commits into
Conversation
- Fix rejection of invalid WIFs - Always wipe decoded WIF key when rejecting - Return WALLY_ENOMEM on memory allocation failure
Elements tapscript leaves use leaf version 0xc4, not the BIP-342 0xc0. Add WALLY_LEAF_VERSION_TAPSCRIPT_ELEMENTS and hash it into the tapleaf hash when computing an Elements script path signature hash, with test vectors computed from the Elements test framework's TaprootSignatureHash().
Elements tapscript leaves use leaf version 0xc4, not the BIP-342 0xc0. Use it when hashing Elements taptree leaves, and therefore when computing the merkle root and output key, and in the first byte of control blocks. Add eltr() script tree test vectors computed independently from Elements' taproot_construct().
Require the input to be a version opcode followed by a single direct push of the whole 2-40 byte program, with v0 programs of 20 or 32 bytes.
Nothing is written to either buffer on the failure paths, so just return.
ct() with an ELIP-150 blinding key (a bip32 key or hex key) around a descriptor without the el prefix, e.g. ct(xpub,wpkh(K)), was not marked as Elements. ct() is Elements-only, so mark any ct() descriptor as Elements. Note ct(slip77(...),X) already treated X as Elements.
Check each substitution addition to the descriptor length and fail with WALLY_EINVAL if it would overflow.
Check new size for overflow and check array is being grown.
Thanks to odudex <[email protected]> for the report and test case.
Add array_calloc() to perform overflow checked allocations. Add an exhaustive test for memory allocation failure handling.
Add an exhaustive test for memory allocation failure handling.
Add memory allocation failure handling tests.
The CMake config template spelled the SHA-256 define as HAVE_MBEDTLS_SHA256_H_ (trailing underscore), so src/ccan_config.h never selected the mbedtls backend under CMake and silently built the software SHA-256 instead. The --enable-mbed-tls help string was a copy of the --enable-minimal one.
The HMAC implementation used sizeof() of a hash context member to obtain the block size and used that member as scratch space for the key block. That ties HMAC to the context layout of whichever hashing backend is selected, and is impossible for opaque backends such as PSA Crypto. Use the block size constant of the hash (64 for SHA-256, 128 for SHA-512) and a local key block instead. The byte operations are unchanged for all backends.
jgriffiths
force-pushed
the
scriptint
branch
from
September 29, 2026 08:59
5b08c09 to
65c8bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.