Repository navigation
Patch SDK Vite audit advisory - #1191
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK npm package job on Maple #1190 fails its high-severity audit because
sdk/bun.lockpins Vite 6.4.3. GHSA-587h-7wmj-h5pm includes Vite through 6.4.3 and lists 6.4.4 as the patched 6.x release. This PR changes only the SDK's exact Vite dev-dependency pin and its Bun lock entry; no SDK API or model work changes.Validation with the SDK's pinned Nix/Bun 1.3.5 toolchain:
bun install --frozen-lockfile --lockfile-only --ignore-scriptspasses.bun --no-env-file audit --audit-level=high, fails on the old lock and passes with this patch.git diff --checkpasses.An unrestricted
bun auditstill reports two unrelated moderate transitive findings (sprintf-js,fast-uri); the package gate does not fail on those. The full SDK build and repository pre-commit hook were deferred because the host has less than 5 GiB free. Hosted PR checks will validate the package build.Need help on this PR? Tag
@codesmith-botwith what you need.