Repository navigation
Agent: polish sidebar navigation and settings menu - #1347
AnthonyRonning merged 15 commits into
Conversation
|
hey @matthewrball, love the work here! let me know when you're done making changes so I can review the final version. |
|
one quick design comment. the search box isn't a primary feature, so we'd prefer to decrease its presence in favor of an icon on the toolbar. Here's a quick mockup video I did to show it. I'm happy to make this adjustment on top of your ideas after the fact. Screen.Recording.2026-10-28.at.11.45.30.AM.mov |
|
@matthewrball I like the project selector placement near the composer. Could you move that change, including the draft header cleanup, into a separate PR? I’d like to keep this PR focused on sidebar navigation and settings so we can review and merge each change independently. The New Task styling can stay here. |
|
@matthewrball |
|
Thanks, Mark! I’m splitting the project selector and draft-header cleanup into a separate PR now. I’ll keep this one focused on sidebar navigation, Settings, and New Task styling, and leave the search adjustment to your follow-up. I’ll flag both PRs once the split is ready for review. |
|
@marksftw The split is done! #1347 is focused on sidebar navigation, Settings, and New Task styling; #1353 contains the folder-selector relocation and draft-header cleanup. Both are ready for review, and search is unchanged from upstream in both, so your search follow-up can stay separate. Thanks for the feedback! |
Keep the magnifier visible with either sidebar layout and show the search field only when requested. Omit the idle Search row from local and computer projections, reveal the inserted field correctly, and update keyboard/focus regression coverage. Preserve the contributor New Task appearance and keep project-selector relocation in its separate PR.
|
@matthewrball. looks great! Thanks for separating the project-selector work into #1353. I added a search-only follow-up in
Your New Task styling and the rest of the sidebar/settings work are preserved. The build and formatting checks passed in the pinned Nix environment, and I verified the changed behavior in Maple Work Debug using with manual testing and automated UI testing. |
Keep empty Search in place through pointer activation so its dismissal cannot move the clicked control. Coordinate pointer release with focus-out, preserve keyboard dismissal and explicit reopening, and cover the gesture in GPUI tests. Check task-stepping destinations independently of the optional Search row.
|
@marksftw I pushed a small follow-up in 5cc5d86: empty Search now stays in place until the click completes, so the Projects filter and folder/task menus open on the first click. I also updated the task-stepping assertions and stabilized the cached-bounds menu test, with regression coverage. The full app suites pass locally for both PRs (#1347: 1,145 passed; #1353: 1,141 passed; two ignored each). CI is still awaiting maintainer approval. |
|
I spot-checked your latest changes at |
|
@matthewrball hard to test and review if you keep adding new things to the PR. you done? |
|
in the future, keep the PR in draft until you are done. ready for review means that we can spend time reviewing and merge in if we like it. |
|
not sure about the toolbar change you added last minute. not fully opposed to it, but I'd prefer for you to back it out of this PR so we can focus on the sidebar and settings stuff you put in here. keep it focused. can you do that? |
|
Testing summary for 36 passed; 3 reproduced known preexisting issues. No new regressions found in the covered flows. Coverage included:
The original toolbar background, height, and rounded canvas corner are restored as expected. Known preexisting issues reproduced:
Temporary QA changes and preferences were restored. This pass covered native UI behavior; automated Rust/CI suites were not run. |
|
I'm good with the UX. Ready for review. |
AnthonyRonning
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Why
Settings and feedback are separate footer actions, and the sidebar needs clearer grouping between task creation, navigation, and utilities.
What this PR adds
Draft folder selection and draft-header cleanup are in #1353. The toolbar spacing and canvas-background proposal is separated into #1357, which remains a draft. This PR retains the original 40px toolbar geometry and canvas treatment; Mark’s title-bar Search follow-up is preserved.
Preview
Native Settings menu, cropped to this PR's scope. Usage values are illustrative sample data. The toolbar proposal's previews are in #1357.
Verification
8f147401,cargo test -p maple-agent-app --bin maple-agent --locked -- --test-threads=2: 1,145 passed, 0 failed, 2 ignored.Local checks used Rust 1.96.0 and Xcode 27.1.
just cipassed formatting and the metadata/packaging tests, then stopped on the existing Objective-C macro cfg and nonminimal-boolean Clippy diagnostics in unchanged code. Required pinned-toolchain/platform CI on the current head still needs maintainer workflow approval and a successful result.