Repository navigation
Fix Validate: ignore optional precedent sidecar console errors - #13
Closed
MatthewPaver wants to merge 1 commit into
Closed
MatthewPaver wants to merge 1 commit into
MatthewPaver wants to merge 1 commit into
Conversation
Validate failed on 2026-10-02 because Chromium logs refused (CI) or CORS-blocked (local) fetches to the optional RAG sidecar on :8787 as console errors. The page already falls back offline and requestfailed already ignored the sidecar; apply the same rule to console errors. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
Author
|
Superseded by #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Validate has failed since 2026-10-02 (run 36998319280).
browser_change_assurance.pyasserts no console errors, but Chromium logs the fetch to the optional precedent RAG sidecar (127.0.0.1:8787) as a console error when it is absent (ERR_CONNECTION_REFUSEDin CI) or answers without CORS headers (local). The page already falls back to offline precedents, and therequestfailedlistener already ignored the sidecar — the console listener didn't.Change
One shared
is_sidecar()check, applied to console errors (text and source URL) as well as failed requests. Every other console error still fails the test.Verified
scripts/run_browser_tests.py— all 4 suites pass locally (failed before the change with the same assertion).🤖 Generated with Claude Code