You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[no-ci] fix(bindings): apply CUDA 12 utility runtime fixes on main - #3356
Apply the CUDA 12 utility fixes from #3355 to the source copy already on main: bytes options, coredump buffer ownership, and registered-getter error propagation. Includes the same regression coverage and release notes.
All changes are under cuda_bindings_12/. Landing this separately lets both migration alternatives inherit the reviewed fixes.
Validation
Fresh CUDA 12.9 build; 94 focused tests and full pre-commit passed. Matching CI on #3355 passed all 58 jobs, including the GPU regression paths.
Checklist
I have read the Contributing Guidelines.
New or existing tests cover these changes.
The documentation is up to date with these changes.
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Bug Fixes
Nested resource options now accept both text strings and byte strings, with text consistently encoded as UTF-8. Unsupported value types produce a clearer error.
Coredump settings now keep provided string data available during calls and release getter buffers appropriately.
Errors raised by registered native-handle getters now propagate as-is instead of being reported as an unknown type.
The pull request changes nested character-option conversion, coredump buffer ownership, and native-handle getter error handling. It adds regression coverage and release notes for these fixes.
Nested char elements now encode str values as UTF-8, accept bytes unchanged, and raise TypeError for other types. NVJitLink and NVVM tests cover byte-string options. The release notes describe the change.
get_cuda_native_handle now catches KeyError during getter lookup only. A KeyError raised by a registered getter propagates, as covered by a regression test.
Possibly related PRs
NVIDIA/cuda-python#3182: Implements the same three utility fixes and supporting tests and release notes for the CUDA 12 source tree.
NVIDIA/cuda-python#3173: Integrates the CUDA 12 source tree that this PR updates with the deferred utility fixes.
Suggested reviewers:mdboom
Change: Bug fix
Merge Risk: Minimal · up to 200d3
The reviewed CUDA 12 fixes introduce no identified merge-blocking risk.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingcuda.bindingsEverything related to the cuda.bindings module
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— codex GPT-6 on behalf of Ralf —
Description
Apply the CUDA 12 utility fixes from #3355 to the source copy already on main: bytes options, coredump buffer ownership, and registered-getter error propagation. Includes the same regression coverage and release notes.
All changes are under
cuda_bindings_12/. Landing this separately lets both migration alternatives inherit the reviewed fixes.Validation
Fresh CUDA 12.9 build; 94 focused tests and full pre-commit passed. Matching CI on #3355 passed all 58 jobs, including the GPU regression paths.
Checklist