Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
42adc41 to
f9aa1bf
Compare
a4c1fe7 to
697e3bd
Compare
697e3bd to
7856417
Compare
|
/ok to test 7856417 |
|
7856417 to
b01e4ad
Compare
cc44420 to
4f6212a
Compare
|
/ok to test 4f6212a |
775392e to
341d286
Compare
|
/ok to test 341d286 |
95cf058 to
87c27ce
Compare
87c27ce to
e2338c2
Compare
e2338c2 to
0b5dbe3
Compare
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Nested character values cuda_bindings_12/cuda/bindings/_internal/utils.pyx, cuda_bindings_12/tests/test_nvjitlink.py, cuda_bindings_12/tests/test_nvvm.py |
Nested char elements accept exact str or bytes values. Strings are UTF-8 encoded, while bytes are passed unchanged. Tests cover byte-string options for nvJitLink and NVVM. |
cuCoredumpSettings buffer lifetime cuda_bindings_12/cuda/bindings/_lib/utils.pxd, cuda_bindings_12/cuda/bindings/_lib/utils.pxi |
The helper retains init_value for setter-side file and pipe settings. Its destructor frees _charstar only for getters. |
Native handle getter errors cuda_bindings_12/cuda/bindings/utils/__init__.py, cuda_bindings_12/tests/test_utils.py |
A missing registered getter still raises TypeError. A KeyError raised by a registered getter now propagates. The test checks the propagated error message. |
Possibly related PRs
- NVIDIA/cuda-python#3173: Integrates the CUDA 12 source tree with shared build and test tooling; its scope defers runtime backports to this PR.
Suggested reviewers: mdboom, juenglin
Change: Bug fix
Merge Risk: 
Minimal · up to 0b5db
-
No merge-blocking issue was identified in the runtime maintenance changes.
0b5dbe3 to
1273e61
Compare
Carry forward the runtime behavior from #1665/#1698 with its nvJitLink regression and NVVM bytes-options case. Extracted from #3173 so source integration can be reviewed independently. Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
Carry forward #2399: retain borrowed setter bytes and release getter-owned storage. Keep this runtime maintenance separate from the build integration. Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
Carry forward #2551 and its regression test. A KeyError inside a registered getter must propagate instead of being reported as an unknown handle type. Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
1273e61 to
63e4d8c
Compare
Refs: #3350. Preserve every parameter and assertion; only concurrent execution is disabled for this affected test. Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
— codex GPT-6 on behalf of Ralf —
Layer 8 of 8. Previous: #3178. Functionally independent of the CI layers; stacked only for ordering. Stack map at the bottom.
These fixes are also isolated in #3355 (
12.9.x) and #3356 (main). They remain in this stack until #3356 lands; rebasing afterward will remove the duplicate runtime changes from this layer.What this PR does
Ports three helper fixes that CUDA 13 already has to the CUDA 12 runtime, with their tests. The diff is +48/-4 across 8 files, including a one-line CI workaround: the existing Core pool-trim test runs serially for the known driver synchronization issue #3350. All test cases remain enabled.
bytesas well asstrcompiler options in the nested-resource helper__dealloc__KeyErrorpropagatesWhere to look
cuda_bindings_12/cuda/bindings/_internal/utils.pyx,_lib/utils.pxi,_lib/utils.pxd,utils/__init__.py: read each side by side with its CUDA 13 counterpart.Validation
341d286d(run 40997121153, attempt 3, 105 jobs), including the CUDA 12 suites that select these tests.ede2016affa47ad3b6484a92e16e9fd872447509. Cumulative local validation at cuda.bindings: backport CUDA 12 runtime maintenance fixes #3182: 361 CI-tool tests and full pre-commit passed. fix(bindings): backport CUDA 12 utility runtime fixes #3355 passed all 58 CI jobs, including the CUDA 12 GPU regressions. Full CI on alternative #3322 passed (105 successful jobs; one expected skip).Stack map: review scopes and merge units
cuda_bindings_12/, byte-identical to the12.9.xbranchmain; planner; version preview bootstrapbackport_branchLayers 3 to 5 are review boundaries, not working intermediate states: #3174 alone breaks CI (workflows still read the removed
cuda.build.version), and #3175 alone fails actionlint (callers pass an input the test workflows only accept in #3176). The plan is to review them separately and land the reviewed group as one merge. #3176 is the full-CI target for the group.The staged stack #3314-#3322 is the alternative in which every layer is mergeable on its own; both stacks reach the same end state, except that the staged stack keeps compatibility routes for older artifact sources and retained CUDA 13 tags.