Repository navigation
Conversation
Thin identity-band crops make RapidOCR read "Smith," as "Smith." (seen on native Windows). That punctuation mismatch fired affirmative contradiction budgets and returned mismatch instead of the glyph-collapse abstain the homonym fixtures require. Drop comma and period from the squashed comparison form so the existing abstain assertions hold on Windows and Linux without loosening the tests.
abrichr
added
the
review-needed
Stripping every period turned DOBs like 01.01.1900 into 01011900, which the glyph-vulnerable-identifier gate then treated as an MRN-like token and spuriously abstained (CI Hypothesis fuzz on shard 1/3). Keep periods between digits; still drop OCR-volatile trailing comma/period on names so Smith,/Smith. compare equal.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1842
Summary
Native Windows RapidOCR reads
Smith,asSmith.(and the reverse) when the identity band is the thin compile/replay crop. That punctuation-only difference fired affirmative contradiction / unexplained-name budgets, so the OCR tier returnedmismatchinstead of the glyph-collapseabstainthe existing homonym fixtures require.squashnow drops comma and period from the comparison form. Fail-closed sibling probes (John/Joan and the rest) are unchanged.Testing
test_wrong_patient_does_not_verify_via_real_replayer_ocr_tierandtest_numeric_100512_collapses_and_abstains_arialpass; 687 pure identity/template/evidence tests pass.squash("Smith,") != squash("Smith.").Untested