Repository navigation
Conversation
Closes the realism-audit bookkeeping for OpenAdapt#1472. Neighbouring and fuzzy read-back confirms were removed in #1747; the Hypothesis controls in test_realism_readback_values.py pass on main.
abrichr
added
the
review-needed
Closes the realism-audit bookkeeping for OpenAdapt#1476. Paged search-sets are followed whole (or read as unreadable) since #1538; test_effect_paging.py pins the controls.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1472.
Summary
#1747 already made on-screen read-back confirm only an exact, typed whole-field value. Neighbouring amounts (
$1,250.00vs250,Qty 15vs5), trailing credit markers (100.00-,$100.00 CR), and fuzzy longest-run text (2026-10-29vs2026-10-21,smithsonvsSmith) no longer confirm a write.This PR updates
docs/audits/REALISM_AUDIT.mdranks 4 and 9 from OPEN/xfail to fixed by #1747, matching the Hypothesis controls that already pass on main.Testing
pytest -q packages/flow/tests/test_realism_readback_values.py -n 4— 9 passedcompare_value/value_matches— all mismatch / FalseUntested