Repository navigation
Remove stale generateApplicationFormJson script - #311
Merged
Merged
Conversation
bickelj
reviewed
Oct 6, 2026
bickelj
left a comment
bickelj
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but then again I was the one who prompted it.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Removes the obsolete application-form JSON generator and its npm script entry.
Changes:
- Deletes
src/generateApplicationFormJson.ts. - Removes the corresponding npm script from
package.json.
| File | Description |
|---|---|
src/generateApplicationFormJson.ts |
Removes stale generator code. |
package.json |
Removes its npm script entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The script predates two API changes: GET /baseFields now returns a bundle object instead of a bare array, and it is paginated with a default _count of 10. As written it crashes on the bundle response (fields.filter is not a function) and would silently see only 10 of 282 fields even if it did not. Nothing else references the script or its npm script entry, so delete both rather than maintain dead code. GLM-5.3-Flash, an LLM supervised and prompted by @bickelj Issue PhilanthropyDataCommons/service#2619 Base Fields Sync description did not update
bickelj-agent
force-pushed
the
remove-stale-application-form-json
branch
from
October 6, 2026 16:19
d673e38 to
250cf0a
Compare
grant-minor-sntialtech
approved these changes
Oct 7, 2026
grant-minor-sntialtech
left a comment
grant-minor-sntialtech
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm script's fetch of GET /baseFields predates the endpoint returning a bundle instead of a bare array and the endpoint becoming paginated (default _count=10), so it crashes at runtime and would only ever see the first 10 of 282 fields. Delete the script and its npm script entry rather than maintain dead code; nothing else references them.
Issue PhilanthropyDataCommons/service#2619 Base Fields Sync description did not update
GLM-5.3-Flash, an LLM supervised and prompted by @bickelj