Repository navigation
Conversation
The split branch's tree is already contained in this branch. Co-Authored-By: Claude Opus 5.5 <[email protected]>
zzylol
force-pushed
the
test/promql-exact-function-coverage
branch
from
September 29, 2026 01:27
6042bb0 to
649fe08
Compare
This was referenced Sep 29, 2026
zzylol
changed the base branch from
test/promql-exact-function-coverage
to
split/erp-workload-costs
September 29, 2026 01:27
Contributor
Author
|
Closing: the code this PR changes was removed by #818, which replaced the old backend with the stack that executes ASAPPlanner's selected plan. |
zzylol
added a commit
that referenced
this pull request
Oct 21, 2026
…frontend only (#843) fix(deps): pin ASAPPlanner 7565c47e; depend on asap-planner's PromQL frontend only Pin both Planner crates to ASAPPlanner 7565c47e, which brings: - #780: a gauge declared non-negative (SourceFacts::values_non_negative) lets a per-series quantile sketch's relative error carry through sum and avg, and a quantile estimate carries its samples' sign; - #782: the SQL and MetricsQL frontends are optional features. asap-planner is now used with default-features = false, features = ["promql"], so DataFusion and the SQL and MetricsQL frontends drop out of the build (Cargo.lock: -1,847 lines). The sync script accepts a pin followed by other keys, such as features. Not yet: ASAPPlanner #787 (StoredOutput.coverage and inputs replace pane); that adaptation comes next.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject cost evidence that quotes another dataset
Stacked between #786 and #742: #728 → #786 → this PR → #742 → #775.
Before:
WorkloadCostEvidencequotes are matched to candidates by full manifest equality. A quote whosedataset_identitydiffers from the deployment simply fails to match, so a foreign quote is silently ignored and the remaining quotes still choose the plan. Only when every quote is foreign does selection fail, and then with a generic "no feasible completely costed candidate" error.After:
WorkloadCostEvidence::validatecompares every quote'smanifest.dataset_identity(bothnamespaceanddataset) withPhysicalDeploymentContext.dataset_identity. One evidence generation prices one dataset, so a single foreign quote rejects the whole generation with a typed error:No wire-format change: evidence gains no top-level field; the identity already carried by each quote is checked.
Tests
evidence_quoting_another_dataset_is_rejected_wholecovers:namespace→CostEvidenceDatasetwith the expected/found identities;dataset→ same error;select_lowest_cost_candidate(PromQL) andselect_lowest_cost_metricsql_candidate.Validation
cargo test -p control_plane --lib: 450 passed.cargo test -p control_plane --no-fail-fast: all test targets pass exceptdiscovery_snapshot(unsupported workload snapshot version 2; only version 3 is supported), which fails identically on the test: assert Level-1 candidate membership and account for every rejection #728 base and is unrelated to this change.🤖 Generated with Claude Code