Repository navigation
feat(hash,serve): port graph-hashing and cache fixes inspired by uber… - #520
Merged
tinder-maxwellelliott merged 2 commits intoOct 15, 2026
Merged
tinder-maxwellelliott merged 2 commits into
tinder-maxwellelliott merged 2 commits into
Conversation
…/tango Hashing: - A source label that names a directory now hashes the whole tree (names, kinds, contents, exec bits, symlink targets). Previously a directory was hashed as a missing file, so edits inside it never impacted anything. - Repository rules (//external:*) pinned by sha256 or integrity are hashed without url/urls: a mirror or registry move cannot change what they fetch. - The main-repository files a repository rule's attributes name (patches, build files, lock files) are hashed by content into the repository's definition, so a changed patch is a changed repository. - Dependency cycles in the query graph no longer fail hashing. The back edge is hashed from the entered target's own definition and targets are visited in label order, so the digest is deterministic regardless of query output order. A one-line warning names each cycle. serve: - Cache entries are keyed by the commit's tree hash instead of its SHA, so a rebase, an amended message, or a merge commit that changes no file reuses the entry. - Full-content hashes seed source hashes from `git ls-tree` blob ids instead of reading every tracked file. The scoped modifiedFilepaths path keeps its disk-read semantics, and the configuration fingerprint carries a token so entries from builds without this seeding are never mixed in. Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01MhitctFYvdY81RzRSxpqgN
|
Have you taken a look at Tango's graph caching and diffing feature to skip calling bazel query? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/tango
Hashing:
serve:
git ls-treeblob ids instead of reading every tracked file. The scoped modifiedFilepaths path keeps its disk-read semantics, and the configuration fingerprint carries a token so entries from builds without this seeding are never mixed in.