Skip to content

feat: import local and NFS folders in place - #558

Merged
St4NNi merged 25 commits into
mainfrom
feat/nfs-folder-import
Nov 4, 2026
Merged

St4NNi merged 25 commits into
mainfrom
feat/nfs-folder-import

Conversation

@St4NNi

@St4NNi St4NNi commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

Lets a node operator approve local or NFS folders that groups can import in place. A group registers a storage backend of kind fs inside an approved folder and imports it with the existing backend import. Access never follows a symlink below the approved folder, and Aruna writes into a folder only when the operator allows it. Follows #556.

Changes

  • New local_fs OpenDAL service: never follows symlinks below its root, lists each folder in sorted key order so imports can resume with start_after (no 100,000 entry limit), takes a path filter hook, and writes only when enabled. Works on macOS, Linux and Windows.
  • [import_root.<name>] in the node's backends file with path, groups and writable (off by default).
  • Group backend kind fs with root (an import root name, never a path) and an optional folder, checked against the node's import roots.
  • GET /data/groups/{group_id}/storage/import-roots lists the roots a group may use, without paths.
  • fs backends are kept out of default and bucket routing; an import from a read-only folder needs a writable write backend.
  • README section for operators, with NFS mount advice.
  • CI job platform-tests runs the folder service tests on macOS and Windows.
  • Workspace version 3.0.0-alpha.147.

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.53125% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.40%. Comparing base (69588b6) to head (5c93c85).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
blob/src/local_fs.rs 88.49% 61 Missing ⚠️
blob/src/blob/group.rs 93.54% 10 Missing ⚠️
blob/src/blob/external_tests.rs 96.72% 4 Missing ⚠️
aruna/src/startup/listeners.rs 75.00% 3 Missing ⚠️
operations/src/groups/backends/validation.rs 96.82% 2 Missing ⚠️
api/src/routes/storage/group_backends.rs 98.03% 1 Missing ⚠️
core/src/structs/storage/group_backend.rs 95.45% 1 Missing ⚠️
operations/src/groups/backends/replace.rs 80.00% 1 Missing ⚠️
operations/src/groups/storage_routing.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
+ Coverage   89.39%   89.40%   +0.01%     
==========================================
  Files        1487     1492       +5     
  Lines      618020   619967    +1947     
==========================================
+ Hits       552487   554297    +1810     
- Misses      65533    65670     +137     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from feat/live-backup to main November 3, 2026 21:39
@St4NNi
St4NNi merged commit 65e559a into main Nov 4, 2026
29 checks passed
@St4NNi
St4NNi deleted the feat/nfs-folder-import branch November 4, 2026 06:29

This branch was previously deployed

1 inactive deployment
coverage — 5c93c858 Deployed Nov 4, 2026 by St4NNi via Generate Coverage Report #1020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant