Repository navigation
Update swift-protobuf to 1.39.0 - #59
Merged
Merged
Conversation
Homebrew's protoc-gen-swift is 1.39.0, which generate-proto.sh needs to match the package. It generates the same Swift for today's protocol, so only the version changes. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01R2bAq6kZW6eyymkA3zsd4p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew's swift-protobuf, which
scripts/generate-proto.shuses, is now 1.39.0, and the generator should match the package's runtime. This moves the package pin (andPackage.resolved) to 1.39.0 and updates the script's note.1.39.0 generates exactly the same Swift for today's protocol, so
remotecontrolmessages.pb.swiftis unchanged.swift testinPackages/ClementineKit(134 tests) andscripts/build.shpass.Generated by Claude Code