Repository navigation
tests: Read the exfatprogs version from stderr too - #2
Closed
davidvornholt wants to merge 1 commit into
Closed
davidvornholt wants to merge 1 commit into
davidvornholt wants to merge 1 commit into
Conversation
Since exfatprogs 1.4.4, "mkfs.exfat --version" prints the exfatprogs version to stderr and only the libblkid version to stdout, so the version check failed and all exFAT test classes errored out in setup. Fixes: storaged-project#1225 Assisted-by: Claude Code (Claude Opus 5.5)
davidvornholt
marked this pull request as draft
November 13, 2026 17:09
Owner
Author
Review
Gate on
Remaining risk. No one has run the seven exFAT test classes against exfatprogs 1.4.4 yet: upstream CI stops at the setup error, and the suite needs root here. The Fedora 45 and Rawhide testing-farm jobs on the upstream pull request will be the first run. |
davidvornholt
marked this pull request as ready for review
November 13, 2026 17:14
Owner
Author
|
Sent upstream in storaged-project#1227. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Since exfatprogs 1.4.4,
mkfs.exfat --versionprints the exfatprogs version to stderr and only the libblkid version to stdout (exfatprogs commit)._get_exfatprogs_versioninexfat_test.pyonly searched stdout, so all seven exFAT test classes error out in setup. exfatprogs 1.4.4 reached Fedora Rawhide on November 10 and Fedora 45 on November 13, so the libblockdev test jobs on Fedora now fail this way on every pull request, for example on Rawhide in storaged-project#1224 and on Fedora 45 and Rawhide in storaged-project#1226. This change searches both outputs.Fixes storaged-project#1225
The library itself isn't affected:
mkfs.exfat --versionexits with 1, andbd_utils_check_util_versionthen searches both stdout and stderr.I ran
_get_exfatprogs_versionwith the realrun_commandagainst exfatprogs 1.3.2 and 1.4.4. It returns the right version for both, and without the change it raises the error from the issue with 1.4.4. I didn't run the exFAT test classes themselves, because I can't run the suite as root here.I used Claude Code (Claude Opus 5.5) to investigate, write and test this change and this description, and reviewed both myself.