Skip to content

tests: Read the exfatprogs version from stderr too - #2

Closed
davidvornholt wants to merge 1 commit into
masterfrom
exfatprogs-version-stderr
Closed

davidvornholt wants to merge 1 commit into
masterfrom
exfatprogs-version-stderr

Conversation

@davidvornholt

@davidvornholt davidvornholt commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Hi! Since exfatprogs 1.4.4, mkfs.exfat --version prints the exfatprogs version to stderr and only the libblkid version to stdout (exfatprogs commit). _get_exfatprogs_version in exfat_test.py only searched stdout, so all seven exFAT test classes error out in setup. exfatprogs 1.4.4 reached Fedora Rawhide on November 10 and Fedora 45 on November 13, so the libblockdev test jobs on Fedora now fail this way on every pull request, for example on Rawhide in storaged-project#1224 and on Fedora 45 and Rawhide in storaged-project#1226. This change searches both outputs.

Fixes storaged-project#1225

The library itself isn't affected: mkfs.exfat --version exits with 1, and bd_utils_check_util_version then searches both stdout and stderr.

I ran _get_exfatprogs_version with the real run_command against exfatprogs 1.3.2 and 1.4.4. It returns the right version for both, and without the change it raises the error from the issue with 1.4.4. I didn't run the exFAT test classes themselves, because I can't run the suite as root here.

I used Claude Code (Claude Opus 5.5) to investigate, write and test this change and this description, and reviewed both myself.

Since exfatprogs 1.4.4, "mkfs.exfat --version" prints the exfatprogs
version to stderr and only the libblkid version to stdout, so the
version check failed and all exFAT test classes errored out in setup.

Fixes: storaged-project#1225

Assisted-by: Claude Code (Claude Opus 5.5)
@davidvornholt
davidvornholt marked this pull request as draft November 13, 2026 17:09
@davidvornholt

davidvornholt commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner Author

Review

Review Reviewers Findings Outcome
ced1904d..2094ce68 Behavior, premise (GPT-6 Astra, high) 1 defer Description corrected, no code change
Fix review None None Skipped, because there were no fix commits

Gate on 2094ce68: codespell clean, py_compile passes, and _get_exfatprogs_version with the real run_command returns 1.3.2 and 1.4.4 for exfatprogs 1.3.2 and 1.4.4, and raises the storaged-project#1225 error with 1.4.4 on the base commit. Total time: 5 minutes.

Where What goes wrong Reported by Label Outcome
Description, first paragraph It said the Fedora testing-farm runs fail this way on every pull request, but the udisks job on storaged-project#1226 fails for an unrelated btrfs reason that this change doesn't fix. Premise defer Fixed in the description, because that text goes upstream: it now names only the libblockdev test jobs.

Remaining risk. No one has run the seven exFAT test classes against exfatprogs 1.4.4 yet: upstream CI stops at the setup error, and the suite needs root here. The Fedora 45 and Rawhide testing-farm jobs on the upstream pull request will be the first run.

@davidvornholt

Copy link
Copy Markdown
Owner Author

Sent upstream in storaged-project#1227.

@davidvornholt
davidvornholt deleted the exfatprogs-version-stderr branch November 16, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test suite fails with exfatprogs 1.4.4

1 participant