Repository navigation
tests: Read the exfatprogs version from stderr too - #1227
vojtechtrefny merged 1 commit into
Conversation
Since exfatprogs 1.4.4, "mkfs.exfat --version" prints the exfatprogs version to stderr and only the libblkid version to stdout, so the version check failed and all exFAT test classes errored out in setup. Fixes: storaged-project#1225 Assisted-by: Claude Code (Claude Opus 5.5)
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
6e7d52d
into
storaged-project:master
Hi! Since exfatprogs 1.4.4,
mkfs.exfat --versionprints the exfatprogs version to stderr and only the libblkid version to stdout (exfatprogs commit)._get_exfatprogs_versioninexfat_test.pyonly searched stdout, so all seven exFAT test classes error out in setup. exfatprogs 1.4.4 reached Fedora Rawhide on November 10 and Fedora 45 on November 13, so the libblockdev test jobs on Fedora now fail this way on every pull request, for example on Rawhide in #1224 and on Fedora 45 and Rawhide in #1226. This change searches both outputs.Fixes #1225
The library itself isn't affected:
mkfs.exfat --versionexits with 1, andbd_utils_check_util_versionthen searches both stdout and stderr.I ran
_get_exfatprogs_versionwith the realrun_commandagainst exfatprogs 1.3.2 and 1.4.4. It returns the right version for both, and without the change it raises the error from the issue with 1.4.4. I didn't run the exFAT test classes themselves, because I can't run the suite as root here.I used Claude Code (Claude Opus 5.5) to investigate, write and test this change and this description, and reviewed both myself.
I reviewed this first in my fork, in davidvornholt#2. The code is unchanged since then.
Summary by CodeRabbit