Repository navigation
chore(deps): take tailwind-variants 4, ondocs 0.18 and the open patches - #284
Merged
Merged
Conversation
The five open Dependabot pull requests (#279 to #283) in one change: - tailwind-variants 3.3.1 -> 4.0.2, a major, in the root's dev dependencies and examples/react-aria. Both only call tv() with base, variants, compoundVariants, defaultVariants and extend, which 4 keeps; nothing uses twMergeConfig, cn or the lite entry, which it changes. The example typechecks on 4, and inspect reads the same components, props and variants from it and from test/fixtures/rac-ui as on 3. - ondocs 0.10.0 -> 0.18.0 in site. The site uses none of the options that 0.14 renamed, and its tests, typecheck and build pass. - @modelcontextprotocol/server 2.3.1 -> 2.4.0 and zod 4.6.6 -> 4.6.7, inside the published package's ranges (^2.3.1, ^4.6.6), so only the lockfile moves and the built dist/ is byte for byte the same. - prettier 3.10.1, typescript-eslint 8.72.2 and @next/eslint-plugin-next 16.4.6 (dev). The published package's dependency ranges do not change, so there is no changeset.
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging #278 let Dependabot open its next five pull requests. This takes all five in one change, including the tailwind-variants 4 major, which I migrated rather than held back: nothing here uses what 4 changes. Besides the lockfile, only three
package.jsonranges change: tailwind-variants in the root andexamples/react-aria, and ondocs insite.Supersedes #279, #280, #281, #282, #283.
Updates
prettiertypescript-eslintsite, dev@next/eslint-plugin-nextsite, devtailwind-variants^3.3.1)^4.0.2)examples/react-ariaondocs^0.10.0)^0.18.0)site@modelcontextprotocol/serverdependencies,^2.3.1)zoddependencies,^4.6.6), and everything else that uses itThese are the versions Dependabot proposed. Each pull request's CI passed, apart from one Windows job on #281 (below).
tailwind-variants 4
I read the v3 to v4 migration guide. 4 moves
twMergeConfigtotailwind-variants/config, dropsexperimentalParseClassName, returns""instead ofundefinedfor empty class lists, changescnwith a numeric0and the lite entry'stwMerge, rejects unknown variant and slot keys at compile time, and stops listingtailwind-mergeandtailwindcssas peers.Where it's used:
examples/react-aria:tv()inButton,Checkbox,Field,Switchandutils.ts.test/fixtures/rac-ui(React Aria's Tailwind starter) resolvestvand its types in the tests.test/variant-values.test.ts), which the extractor reads without installing anything.All of them call
tv()withbase,variants,compoundVariants,defaultVariantsandextend, which 4 keeps. None usestwMergeConfig,experimentalParseClassName,cn,createTVor the lite entry. So the migration is the range change:examples/react-ariatypechecks on 4, so none of its definitions has a key that 4's stricter types reject.onsystem inspect --format jsononexamples/react-ariaand ontest/fixtures/rac-uigives the same output with 4 as with 3.3.1 onmain(3,387 and 3,196 lines: every component, prop, variant and token), apart from the root path and timing.test/react-aria.test.ts,test/component-guesses.test.ts,test/example.test.tsandtest/variant-values.test.tspass.extend: [a, b]form needs no change in the extractor either: it treats anyextendas adding its base's values, which is right for an array too.The example keeps
tailwind-merge, which itscomposeTailwindRenderPropscalls itself, as React Aria's starter does. The guide suggests one merger per app to save bundle size; the example isn't bundled, so I left it as the starter has it.ondocs 0.18
ondocs is used only by
site(a private workspace package): the Ask dialog (ondocs/react), the Ask and MCP endpoints (ondocs/server) and the search index thatscripts/generate.mjsbuilds. I read the release notes from 0.11 to 0.18:rateLimitFailureis nowfailureMode, the Astro and VitePresscontent/ignoreoptions,ondocs init --out). The site uses none of them.localeargument tosearchandlist_pages. The site has one locale, and it still serves the same three MCP tools thatMCP_TOOLSinsite/lib/ask.tslists.The site's
generate,test(295 tests, including the Ask and MCP endpoint tests intest/ask.test.ts),typecheck,lintandbuildpass on 0.18.0. ondocs 0.18.0 brings no new packages into the lockfile.@modelcontextprotocol/server 2.4.0 and zod 4.6.7
Both are in the published package's
dependencies, and both stay inside its ranges, so only the lockfile moves. A new install of onsystem already gets these versions. Both stay external in the build, sodist/andschema.jsonare byte for byte the same as onmain. The 2.4.0 changes are the Skills extension on new subpaths, anx-mcp-headercheck onnumberparameters, andoutputSchemaroots that are a$ref. onsystem's server uses none of these, andpnpm smokepasses on both protocol versions.@modelcontextprotocol/core2.3.1 leaves the lockfile: the server and the client now share 2.4.0.How they were applied
The same steps as #278. I changed the three ranges that #280 and #281 change, added exact overrides for the five lockfile-only moves (
[email protected]: 4.6.7, and so on) topnpm-workspace.yaml, ranpnpm install, removed the overrides and ranpnpm installagain. The lockfile has nooverridessection andpnpm-workspace.yamlis unchanged.The package lists of the two lockfiles differ only in the versions in the table, the
@typescript-eslint/*packages that move to 8.72.2 with typescript-eslint, and@modelcontextprotocol/core2.3.1 leaving. Dependabot's own lockfiles also moved vite's rolldown from 1.2.15 to 1.2.19, and #279 moved ignore, semver and@eslint-community/regexpp. This branch leaves those as they are onmain.Every new version is more than 24 hours old, and pnpm reported that the lockfile passes its supply-chain checks.
Who is affected
Users of the npm package are not. Its
dependenciesranges andpeerDependenciesdon't change, and the built package is identical tomain's. tailwind-variants is a dev dependency of the root and a dependency of a private example, and ondocs is a dependency of the privatesite. So there is no changeset.The failing job on #281
On #281, "Test on windows-latest" failed in
test/npm-readme.test.ts("keeps the demo video on GitHub and shows the hero image in the packed package"):Test timed out in 30000ms. That test runsnpm packon the root package, which ondocs (asitedependency) doesn't touch. The test passes in #281's other four test jobs, the Windows job passes on the other four pull requests, and the test passes here. It looks like a slow Windows runner.Checks
On a clean
node_modules, with the new lockfile:pnpm install --frozen-lockfile: passpnpm lint,pnpm format:check,pnpm typecheck: pass. Prettier 3.10.1 reformats nothing, and typescript-eslint 8.72.2 reports nothing new.pnpm --filter "./examples/*" typecheck: pass, all three examples,examples/react-ariaon tailwind-variants 4.0.2pnpm build: pass, publint clean.dist/andschema.jsonare identical tomain's.pnpm smoke: pass, on both protocol versionsapp/settings/members.tsxpasses, and the Claude Code hook blocksapp/settings/danger-zone.tsxwith exit code 2 andno-unknown-variantpnpm test: 115 files pass and 1 is skipped; 1,500 tests pass and 3 are skippedpnpm test:coverage: pass, above the thresholds (lines 95.74%, branches 87.46%, functions 95.69%, statements 93.59%)pnpm pack-test: pass, including the ESLint 8.57.0 projectgenerate, thentest(22 files, 295 tests, all pass),typecheck,lintandbuild: passNo new tests: no code changes.