Skip to content

chore(deps): take tailwind-variants 4, ondocs 0.18 and the open patches - #284

Merged
dgesteves merged 1 commit into
mainfrom
chore/deps-2026-11-16-b
Nov 16, 2026
Merged

dgesteves merged 1 commit into
mainfrom
chore/deps-2026-11-16-b

Conversation

@dgesteves

Copy link
Copy Markdown
Owner

Merging #278 let Dependabot open its next five pull requests. This takes all five in one change, including the tailwind-variants 4 major, which I migrated rather than held back: nothing here uses what 4 changes. Besides the lockfile, only three package.json ranges change: tailwind-variants in the root and examples/react-aria, and ondocs in site.

Supersedes #279, #280, #281, #282, #283.

Updates

Package Old New Where From
prettier 3.9.10 3.10.1 root, dev #279
typescript-eslint 8.72.1 8.72.2 root and site, dev #279
@next/eslint-plugin-next 16.4.5 16.4.6 site, dev #279
tailwind-variants 3.3.1 (^3.3.1) 4.0.2 (^4.0.2) root (dev), examples/react-aria #280
ondocs 0.10.0 (^0.10.0) 0.18.0 (^0.18.0) site #281
@modelcontextprotocol/server 2.3.1 2.4.0 root (the published package's dependencies, ^2.3.1) #282
zod 4.6.6 4.6.7 root (the published package's dependencies, ^4.6.6), and everything else that uses it #283

These are the versions Dependabot proposed. Each pull request's CI passed, apart from one Windows job on #281 (below).

tailwind-variants 4

I read the v3 to v4 migration guide. 4 moves twMergeConfig to tailwind-variants/config, drops experimentalParseClassName, returns "" instead of undefined for empty class lists, changes cn with a numeric 0 and the lite entry's twMerge, rejects unknown variant and slot keys at compile time, and stops listing tailwind-merge and tailwindcss as peers.

Where it's used:

  • examples/react-aria: tv() in Button, Checkbox, Field, Switch and utils.ts.
  • The root's dev dependencies, so that test/fixtures/rac-ui (React Aria's Tailwind starter) resolves tv and its types in the tests.
  • Test fixtures written inline (test/variant-values.test.ts), which the extractor reads without installing anything.

All of them call tv() with base, variants, compoundVariants, defaultVariants and extend, which 4 keeps. None uses twMergeConfig, experimentalParseClassName, cn, createTV or the lite entry. So the migration is the range change:

  • examples/react-aria typechecks on 4, so none of its definitions has a key that 4's stricter types reject.
  • onsystem inspect --format json on examples/react-aria and on test/fixtures/rac-ui gives the same output with 4 as with 3.3.1 on main (3,387 and 3,196 lines: every component, prop, variant and token), apart from the root path and timing.
  • test/react-aria.test.ts, test/component-guesses.test.ts, test/example.test.ts and test/variant-values.test.ts pass.
  • tv's new extend: [a, b] form needs no change in the extractor either: it treats any extend as adding its base's values, which is right for an array too.

The example keeps tailwind-merge, which its composeTailwindRenderProps calls itself, as React Aria's starter does. The guide suggests one merger per app to save bundle size; the example isn't bundled, so I left it as the starter has it.

ondocs 0.18

ondocs is used only by site (a private workspace package): the Ask dialog (ondocs/react), the Ask and MCP endpoints (ondocs/server) and the search index that scripts/generate.mjs builds. I read the release notes from 0.11 to 0.18:

  • 0.14 renamed some options, with the old names still working until 1.0 (rateLimitFailure is now failureMode, the Astro and VitePress content/ignore options, ondocs init --out). The site uses none of them.
  • 0.17 needs Node.js 22.13 or later. CI builds the site on Node 24.
  • 0.18 adds per-locale indexes and a locale argument to search and list_pages. The site has one locale, and it still serves the same three MCP tools that MCP_TOOLS in site/lib/ask.ts lists.

The site's generate, test (295 tests, including the Ask and MCP endpoint tests in test/ask.test.ts), typecheck, lint and build pass on 0.18.0. ondocs 0.18.0 brings no new packages into the lockfile.

@modelcontextprotocol/server 2.4.0 and zod 4.6.7

Both are in the published package's dependencies, and both stay inside its ranges, so only the lockfile moves. A new install of onsystem already gets these versions. Both stay external in the build, so dist/ and schema.json are byte for byte the same as on main. The 2.4.0 changes are the Skills extension on new subpaths, an x-mcp-header check on number parameters, and outputSchema roots that are a $ref. onsystem's server uses none of these, and pnpm smoke passes on both protocol versions. @modelcontextprotocol/core 2.3.1 leaves the lockfile: the server and the client now share 2.4.0.

How they were applied

The same steps as #278. I changed the three ranges that #280 and #281 change, added exact overrides for the five lockfile-only moves ([email protected]: 4.6.7, and so on) to pnpm-workspace.yaml, ran pnpm install, removed the overrides and ran pnpm install again. The lockfile has no overrides section and pnpm-workspace.yaml is unchanged.

The package lists of the two lockfiles differ only in the versions in the table, the @typescript-eslint/* packages that move to 8.72.2 with typescript-eslint, and @modelcontextprotocol/core 2.3.1 leaving. Dependabot's own lockfiles also moved vite's rolldown from 1.2.15 to 1.2.19, and #279 moved ignore, semver and @eslint-community/regexpp. This branch leaves those as they are on main.

Every new version is more than 24 hours old, and pnpm reported that the lockfile passes its supply-chain checks.

Who is affected

Users of the npm package are not. Its dependencies ranges and peerDependencies don't change, and the built package is identical to main's. tailwind-variants is a dev dependency of the root and a dependency of a private example, and ondocs is a dependency of the private site. So there is no changeset.

The failing job on #281

On #281, "Test on windows-latest" failed in test/npm-readme.test.ts ("keeps the demo video on GitHub and shows the hero image in the packed package"): Test timed out in 30000ms. That test runs npm pack on the root package, which ondocs (a site dependency) doesn't touch. The test passes in #281's other four test jobs, the Windows job passes on the other four pull requests, and the test passes here. It looks like a slow Windows runner.

Checks

On a clean node_modules, with the new lockfile:

  • pnpm install --frozen-lockfile: pass
  • pnpm lint, pnpm format:check, pnpm typecheck: pass. Prettier 3.10.1 reformats nothing, and typescript-eslint 8.72.2 reports nothing new.
  • pnpm --filter "./examples/*" typecheck: pass, all three examples, examples/react-aria on tailwind-variants 4.0.2
  • pnpm build: pass, publint clean. dist/ and schema.json are identical to main's.
  • pnpm smoke: pass, on both protocol versions
  • CI's dogfood check of app/settings/members.tsx passes, and the Claude Code hook blocks app/settings/danger-zone.tsx with exit code 2 and no-unknown-variant
  • pnpm test: 115 files pass and 1 is skipped; 1,500 tests pass and 3 are skipped
  • pnpm test:coverage: pass, above the thresholds (lines 95.74%, branches 87.46%, functions 95.69%, statements 93.59%)
  • pnpm pack-test: pass, including the ESLint 8.57.0 project
  • Site: generate, then test (22 files, 295 tests, all pass), typecheck, lint and build: pass

No new tests: no code changes.

The five open Dependabot pull requests (#279 to #283) in one change:

- tailwind-variants 3.3.1 -> 4.0.2, a major, in the root's dev
  dependencies and examples/react-aria. Both only call tv() with base,
  variants, compoundVariants, defaultVariants and extend, which 4 keeps;
  nothing uses twMergeConfig, cn or the lite entry, which it changes.
  The example typechecks on 4, and inspect reads the same components,
  props and variants from it and from test/fixtures/rac-ui as on 3.
- ondocs 0.10.0 -> 0.18.0 in site. The site uses none of the options
  that 0.14 renamed, and its tests, typecheck and build pass.
- @modelcontextprotocol/server 2.3.1 -> 2.4.0 and zod 4.6.6 -> 4.6.7,
  inside the published package's ranges (^2.3.1, ^4.6.6), so only the
  lockfile moves and the built dist/ is byte for byte the same.
- prettier 3.10.1, typescript-eslint 8.72.2 and
  @next/eslint-plugin-next 16.4.6 (dev).

The published package's dependency ranges do not change, so there is
no changeset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant