Repository navigation
perf(sm120): optimize DeepSeek-V4.1 inference - #1788
Conversation
Signed-off-by: AlpinDale <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f653ba4e15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: AlpinDale <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 346b243b27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
…layer Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
4673948 to
9c15e64
Compare
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
…all-reduce Signed-off-by: AlpinDale <[email protected]>
…port Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
… draft sampler Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
…ages in prompt order Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Honor the configured row threshold, preserve global metadata offsets, and gather ragged selected-index shards before attention. Keep pure decode, capture, and the wide candidate producer on their existing paths. Document the existing nondeterministic boundary-tie selection policy rather than promising bit-identical production indices. Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
Move SM120 and PCIe sources into subsystem directories with local operator registration. Keep model preparation, configuration, rendering and worker lifecycle helpers feature-owned. Include draft TP faults in final output gating, enforce fused MoE staging bounds and preserve canonical NVFP4 gate/up layout. Replace stale implementation-detail assertions with numerical and consumer-visible regressions. Signed-off-by: AlpinDale <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abd41971d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* Add checked host-memory collectives for non-P2P SM120 TP4 Signed-off-by: AlpinDale <[email protected]> * Specialize small host collectives and shard large reductions Signed-off-by: AlpinDale <[email protected]> * Avoid redundant host input copies on lane owners Signed-off-by: AlpinDale <[email protected]> --------- Signed-off-by: AlpinDale <[email protected]>
Signed-off-by: AlpinDale <[email protected]>
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Optimizes DeepSeek-V4.1-Flash prefill and batched decode on SM120 with bounded DSA indexing, fused kernels, native MoE, live-row Engram, TP-sharded DSpark, and opt-in paired PCIe collectives. Sparse MLA/MoE kernels adapt BRRR/vLLM-Moet. Keeps sources, registrations, preparation and configuration with subsystem owners. Fixes V4.1 tool/media ordering, MoE layout/bounds, and late-draft fault propagation.
Performance
4× RTX PRO 6000 Blackwell, TP4, 1,048,576-token context, MNBT4096, DSpark K7, 2,048 output tokens,
thinking=false. Rates are aggregate tok/s; TTFT is p50/p95 in seconds.PR
abd41971d3: three measured batches per cell from one fresh server; main: six batches from two servers. Warmups excluded. Prefill uses cold one-token requests; decode uses warm prefixes and exact token IDs in the common-active window. TTFT uses separate cold 2,048-token requests. Acceptance is pooled over draft tokens.PR: rebuilt SM120 extension, B12x W4A8 + paired PCIe, FP8 SWA/NVFP4 main KV, 90% GPU memory. Main nightly
03fbc02b7, isolated venv: stock Marlin + FlashInfer/NCCL, FP8 KV, 98% GPU memory; stock B12x failed startup. Deployment comparison, not a kernel-only A/B: math/cache modes and draft acceptance differ.Launch
Use FlashInfer 0.7.2's bundled B12x. All four selected GPUs need CUDA peer reads and writes without crossing a NUMA system link. Paired all-reduce is experimental and rounds differently from BF16 NCCL.