ref(strawberry)!: Drop send_default_pii support in request data - #7869
Open
ericapisani wants to merge 2 commits into
Open
ericapisani wants to merge 2 commits into
ericapisani wants to merge 2 commits into
Conversation
The request event processor now reads only the `data_collection` options for the GraphQL document and variables, and no longer falls back to `send_default_pii`. It also no longer removes `request.data` when neither option is set, so a body attached by the web framework integration is left untouched (as the attaching of the body is controlled by the `http_bodies` property in the `data_collection` settings) Fixes PY-2843 Fixes #7614
ericapisani
commented
Oct 5, 2026
|
|
||
| else: | ||
| try: | ||
| del event["request"]["data"] |
Member
Author
There was a problem hiding this comment.
whether this is added or not is now controlled by the data_collection.http_bodies flag within _wsgi_common, so this doesn't need to be here anymore.
ericapisani
commented
Oct 5, 2026
| assert error_event["exception"]["values"][0]["mechanism"]["type"] == "chained" | ||
| assert error_event["exception"]["values"][-1]["mechanism"]["type"] == "strawberry" | ||
| assert "data" not in error_event["request"] | ||
| assert error_event["request"]["data"] == {"operationName": "ErrorQuery"} |
Member
Author
There was a problem hiding this comment.
In the data collection world we now set operationName unconditionally
ericapisani
marked this pull request as ready for review
October 5, 2026 15:38
Contributor
Codecov Results 📊✅ 56580 passed | ⏭️ 2727 skipped | Total: 59307 | Pass Rate: 95.4% | Execution Time: 151m 38s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2072 uncovered lines. Generated by Codecov Action |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request event processor now reads only the
data_collectionoptions for the GraphQL document and variables, and no longer falls back tosend_default_pii. It also no longer removesrequest.datawhen neither option is set, so a body attached by the web framework integration is left untouched (as the attaching of the body is controlled by thehttp_bodiesproperty in thedata_collectionsettings)Fixes PY-2843
Fixes #7614