Skip to content

ref(strawberry)!: Drop send_default_pii support in request data #7869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericapisani wants to merge 2 commits into
base: major/3.0
Choose a base branch
from
+54 −210
Open

ref(strawberry)!: Drop send_default_pii support in request data #7869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
928369b
ref(strawberry)!: Drop `send_default_pii` support in request data
ericapisani Oct 5, 2026
89dd114
more test cleanups
ericapisani Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 19 additions & 40 deletions sentry_sdk/integrations/strawberry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,50 +366,29 @@ def _make_request_event_processor(
def inner(event: "Event", hint: "dict[str, Any]") -> "Event":
client_options = sentry_sdk.get_client().options
with capture_internal_exceptions():
if has_data_collection_enabled(client_options):
request_data = event.setdefault("request", {})
if client_options["data_collection"]["graphql"]["document"]:
request_data["api_target"] = "graphql"

if not request_data.get("data"):
execution_context_data: "dict[str, Any]" = (
{"query": execution_context.query}
if client_options["data_collection"]["graphql"]["document"]
else {}
)

if (
client_options["data_collection"]["graphql"]["variables"]
and execution_context.variables
):
execution_context_data["variables"] = (
execution_context.variables
)

if execution_context.operation_name:
execution_context_data["operationName"] = (
execution_context.operation_name
)

request_data["data"] = execution_context_data
elif should_send_default_pii():
request_data = event.setdefault("request", {})
request_data = event.setdefault("request", {})
if client_options["data_collection"]["graphql"]["document"]:
request_data["api_target"] = "graphql"

if not request_data.get("data"):
data: "dict[str, Any]" = {"query": execution_context.query}
if execution_context.variables:
data["variables"] = execution_context.variables
if execution_context.operation_name:
data["operationName"] = execution_context.operation_name
if not request_data.get("data"):
execution_context_data: "dict[str, Any]" = (
{"query": execution_context.query}
if client_options["data_collection"]["graphql"]["document"]
else {}
)

request_data["data"] = data
if (
client_options["data_collection"]["graphql"]["variables"]
and execution_context.variables
):
execution_context_data["variables"] = execution_context.variables

else:
try:
del event["request"]["data"]

@ericapisani ericapisani Oct 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whether this is added or not is now controlled by the data_collection.http_bodies flag within _wsgi_common, so this doesn't need to be here anymore.

except (KeyError, TypeError):
pass
if execution_context.operation_name:
execution_context_data["operationName"] = (
execution_context.operation_name
)

request_data["data"] = execution_context_data

return event

Expand Down
Loading
Loading