Repository navigation
ref: Remove should_send_default_pii helpers from client and scope - #7892
Merged
ericapisani merged 1 commit intoOct 6, 2026
Conversation
Drop `BaseClient.should_send_default_pii`, `_Client.should_send_default_pii` and the module-level `scope.should_send_default_pii` shortcut. Fixes PY-2932 Fixes #7882
alexander-alderman-webb
approved these changes
Oct 6, 2026
Contributor
Codecov Results 📊✅ 55379 passed | ⏭️ 2727 skipped | Total: 58106 | Pass Rate: 95.31% | Execution Time: 150m 25s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2061 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.38% 90.03% -0.35%
==========================================
Files 202 185 -17
Lines 26552 20672 -5880
Branches 9858 7116 -2742
==========================================
+ Hits 23997 18611 -5386
- Misses 2555 2061 -494
- Partials 1487 1216 -271Generated by Codecov Action |
ericapisani
merged commit Oct 6, 2026
59aa0c4
into
py-2932-remove-map-send-default-pii
147 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
BaseClient.should_send_default_pii,_Client.should_send_default_piiand the module-levelscope.should_send_default_piishortcut.Fixes PY-2932
Fixes #7882