Skip to content

ref: Remove should_send_default_pii helpers from client and scope #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
Oct 6, 2026
Merged

ref: Remove should_send_default_pii helpers from client and scope #7892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ def dsn(self) -> "Optional[str]":
def parsed_dsn(self) -> "Optional[Dsn]":
return None

def should_send_default_pii(self) -> bool:
return False

def is_active(self) -> bool:
"""
.. versionadded:: 2.0.0
Expand Down Expand Up @@ -441,14 +438,6 @@ def is_active(self) -> bool:
"""
return True

def should_send_default_pii(self) -> bool:
"""
.. versionadded:: 2.0.0

Returns whether the client should send default PII (Personally Identifiable Information) data to Sentry.
"""
return self.options.get("send_default_pii") or False

@property
def dsn(self) -> "Optional[str]":
"""Returns the configured DSN as string."""
Expand Down
5 changes: 0 additions & 5 deletions sentry_sdk/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1870,11 +1870,6 @@ def use_isolation_scope(isolation_scope: "Scope") -> "Generator[Scope, None, Non
capture_internal_exception(sys.exc_info())


def should_send_default_pii() -> bool:
"""Shortcut for `Scope.get_client().should_send_default_pii()`."""
return Scope.get_client().should_send_default_pii()


# Circular imports
from sentry_sdk.client import NonRecordingClient

Expand Down
Loading