Conversation
Materialize HTTP string candidates before computing recursive parent relations, allowing the RA plan to restrict getParent*() and the subsequent private-host antijoin to the filtered candidate set.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The refactor preserves query semantics; only a minor QLDoc placement issue remains.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Refactors HTTP literal filtering to narrow candidates before recursive parent analysis, improving query performance without changing detection logic.
Changes:
- Introduces a private HTTP string candidate class.
- Applies private-host flow filtering only to prefiltered candidates.
| File | Description |
|---|---|
cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql |
Splits candidate selection from recursive private-host filtering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| */ | ||
| class HttpStringLiteral extends StringLiteral { | ||
| HttpStringLiteral() { | ||
| private class HttpStringLiteralCandidate extends StringLiteral { |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Materialize HTTP string candidates before computing recursive parent relations, allowing the RA plan to restrict getParent*() and the subsequent private-host antijoin to the filtered candidate set.