Skip to content

Refactor HttpStringLiteral for performance #22748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbaluda wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −4
Open

Refactor HttpStringLiteral for performance #22748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cpp/ql/src/Security/CWE/CWE-319/UseOfHttp.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,22 @@ predicate privateHostNameFlowsToExpr(Expr e) {
/**
* A string containing an HTTP URL not in a private domain.
*/
class HttpStringLiteral extends StringLiteral {
HttpStringLiteral() {
private class HttpStringLiteralCandidate extends StringLiteral {
HttpStringLiteralCandidate() {
exists(string s | this.getValue() = s |
s = "http"
or
exists(string tail |
tail = s.regexpCapture("http://(.*)", 1) and not tail instanceof PrivateHostName
)
) and
not privateHostNameFlowsToExpr(this.getParent*())
)
}
}

class HttpStringLiteral extends HttpStringLiteralCandidate {
HttpStringLiteral() { not privateHostNameFlowsToExpr(this.getParent*()) }
}

/**
* Taint tracking configuration for HTTP connections.
*/
Expand Down
Loading