Skip to content

feat!: simplify dependencies and abandon - #484

Merged
samuelallan72 merged 1 commit into
masterfrom
samuel/update-deps
Nov 9, 2026
Merged

samuelallan72 merged 1 commit into
masterfrom
samuel/update-deps

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Description

We're no longer maintaining this, so we don't want to deal with the automated dependency upgrade PRs.

Also simplify the dependencies in setup.py, so it will be installable in newer Open edX platform releases without version conflicts. However, note that things could stop working at some point due to incompatibilities anyway.

Also pin setuptools to < 82 to retain pkg_resources.
Ref. https://setuptools.pypa.io/en/stable/history.html#v82-0-0

This should keep it installable at least for Verawood for now.

Supporting information

Ref: #483

Private-ref: https://tasks.opencraft.com/browse/SE-6622

Testing instructions

  • verify you can successfully pip install . for this package in a virtualenv
  • verify the changes make sense and are accurate
  • verify the tests pass

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.04%. Comparing base (b89d041) to head (3bf6d0f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   45.04%   45.04%           
=======================================
  Files          40       40           
  Lines        3303     3303           
  Branches      401      401           
=======================================
  Hits         1488     1488           
  Misses       1768     1768           
  Partials       47       47           
Flag Coverage Δ
unittests 45.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We're no longer maintaining this, so we don't want to deal with the
automated dependency upgrade PRs.

Also simplify the dependencies in setup.py, so it will be installable in
newer Open edX platform releases without version conflicts. However,
note that things could stop working at some point due to
incompatibilities anyway.

Also pin setuptools to < 82 to retain `pkg_resources`.
Ref. https://setuptools.pypa.io/en/stable/history.html#v82-0-0

This should keep it installable at least for Verawood for now.

Ref: #483

Private-ref: https://tasks.opencraft.com/browse/SE-6622
@samuelallan72

Copy link
Copy Markdown
Member Author

I did some spot testing in a verawood devstack on this branch and didn't hit any issues.

@bradenmacdonald bradenmacdonald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test this at the moment, but the code changes look good.

Comment thread setup.py Resolved
@samuelallan72

Copy link
Copy Markdown
Member Author

Thanks @bradenmacdonald ! Let me merge this to unblock the work you're doing in #485 . :)

@samuelallan72 samuelallan72 reopened this Nov 9, 2026
@samuelallan72
samuelallan72 enabled auto-merge (rebase) November 9, 2026 03:59
@samuelallan72
samuelallan72 merged commit 253460a into master Nov 9, 2026
16 checks passed
@samuelallan72
samuelallan72 deleted the samuel/update-deps branch November 9, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants