Repository navigation
feat!: simplify dependencies and abandon - #484
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 40 40
Lines 3303 3303
Branches 401 401
=======================================
Hits 1488 1488
Misses 1768 1768
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
We're no longer maintaining this, so we don't want to deal with the automated dependency upgrade PRs. Also simplify the dependencies in setup.py, so it will be installable in newer Open edX platform releases without version conflicts. However, note that things could stop working at some point due to incompatibilities anyway. Also pin setuptools to < 82 to retain `pkg_resources`. Ref. https://setuptools.pypa.io/en/stable/history.html#v82-0-0 This should keep it installable at least for Verawood for now. Ref: #483 Private-ref: https://tasks.opencraft.com/browse/SE-6622
samuelallan72
force-pushed
the
samuel/update-deps
branch
from
November 3, 2026 02:36
ea27785 to
3bf6d0f
Compare
Member
Author
|
I did some spot testing in a verawood devstack on this branch and didn't hit any issues. |
bradenmacdonald
approved these changes
Nov 3, 2026
bradenmacdonald
left a comment
Member
There was a problem hiding this comment.
I'm not able to test this at the moment, but the code changes look good.
Member
Author
|
Thanks @bradenmacdonald ! Let me merge this to unblock the work you're doing in #485 . :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're no longer maintaining this, so we don't want to deal with the automated dependency upgrade PRs.
Also simplify the dependencies in setup.py, so it will be installable in newer Open edX platform releases without version conflicts. However, note that things could stop working at some point due to incompatibilities anyway.
Also pin setuptools to < 82 to retain
pkg_resources.Ref. https://setuptools.pypa.io/en/stable/history.html#v82-0-0
This should keep it installable at least for Verawood for now.
Supporting information
Ref: #483
Private-ref: https://tasks.opencraft.com/browse/SE-6622
Testing instructions
pip install .for this package in a virtualenv